Re: [PATCH v2] xfs_scrub: don't use statvfs to collect filesystem summary counts

Christoph Hellwig
2020-10-15T08:16:55Z

On Fri, Oct 09, 2020 at 08:37:41AM -0700, Darrick J. Wong wrote:
> > whereas the ioctl looks like it just reads
> > our internal counter (which IIRC is a subset of physically allocated
> > inode chunks). Do we care about that semantic here either way?
>
> Nope. The one caller that cares (scrub/phase7.c) only wants to know the
> number of inodes in use (f_free - f_files), which is unaffected by the
> logic in xfs_fs_statfs.
>
> I suppose I could trim the parameter list even further to return only
> the file count...

Please do. Or just kill the helper entirely and open code the trivial
ioctl call in the two callers.