Re: [PATCH 04/14] iomap: Support THPs in iomap_adjust_read_range

Christoph Hellwig
2020-10-15T09:51:03Z

On Wed, Oct 14, 2020 at 04:03:47AM +0100, Matthew Wilcox (Oracle) wrote:
> Pass the struct page instead of the iomap_page so we can determine the
> size of the page. Use offset_in_thp() instead of offset_in_page() and
> use thp_size() instead of PAGE_SIZE. Convert the arguments to be size_t
> instead of unsigned int, in case pages ever get larger than 2^31 bytes.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> fs/iomap/buffered-io.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 935468d79d9d..95ac66731297 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -82,16 +82,16 @@ iomap_page_release(struct page *page)
> /*
> * Calculate the range inside the page that we actually need to read.
> */
> -static void
> -iomap_adjust_read_range(struct inode *inode, struct iomap_page *iop,
> - loff_t *pos, loff_t length, unsigned *offp, unsigned *lenp)
> +static void iomap_adjust_read_range(struct inode *inode, struct page *page,
> + loff_t *pos, loff_t length, size_t *offp, size_t *lenp)

Can you please stop the pointless reformatting?