From: Christoph Hellwig <hch@infradead.org>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [RFC PATCH] xfs: remove unnecessary null check in xfs_generic_create
Date: Thu, 15 Oct 2020 09:29:42 +0100 [thread overview]
Message-ID: <20201015082942.GD4450@infradead.org> (raw)
In-Reply-To: <1602232150-28805-1-git-send-email-kaixuxia@tencent.com>
On Fri, Oct 09, 2020 at 04:29:10PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The function posix_acl_release() test the passed-in argument and
> move on only when it is non-null, so maybe the null check in
> xfs_generic_create is unnecessary.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-10-15 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 8:29 [RFC PATCH] xfs: remove unnecessary null check in xfs_generic_create xiakaixu1987
2020-10-09 15:45 ` Darrick J. Wong
2020-11-12 2:32 ` kaixuxia
2020-10-15 8:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015082942.GD4450@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox