Re: [PATCH V7 11/14] xfs: Remove duplicate assert statement in xfs_bmap_btalloc()

Darrick J. Wong
2020-10-26T23:12:02Z

On Mon, Oct 19, 2020 at 12:10:45PM +0530, Chandan Babu R wrote:
> The check for verifying if the allocated extent is from an AG whose
> index is greater than or equal to that of tp->t_firstblock is already
> done a couple of statements earlier in the same function. Hence this
> commit removes the redundant assert statement.
>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>

Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_bmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 505358839d2f..64c4d0e384a5 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3699,7 +3699,6 @@ xfs_bmap_btalloc(
> ap->blkno = args.fsbno;
> if (ap->tp->t_firstblock == NULLFSBLOCK)
> ap->tp->t_firstblock = args.fsbno;
> - ASSERT(nullfb || fb_agno <= args.agno);
> ap->length = args.len;
> /*
> * If the extent size hint is active, we tried to round the
> --
> 2.28.0
>