From: Dave Chinner <david@fromorbit.com>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
Date: Tue, 20 Oct 2020 16:04:23 +1100 [thread overview]
Message-ID: <20201020050423.GP7391@dread.disaster.area> (raw)
In-Reply-To: <1603169666-16106-1-git-send-email-kaixuxia@tencent.com>
On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> fs/xfs/libxfs/xfs_format.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index dd764da08f6f..40b6fa3b4e01 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -625,7 +625,6 @@ xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino)
> #define XFS_B_TO_FSB(mp,b) \
> ((((uint64_t)(b)) + (mp)->m_blockmask) >> (mp)->m_sb.sb_blocklog)
> #define XFS_B_TO_FSBT(mp,b) (((uint64_t)(b)) >> (mp)->m_sb.sb_blocklog)
> -#define XFS_B_FSB_OFFSET(mp,b) ((b) & (mp)->m_blockmask)
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-10-20 5:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 4:54 [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro xiakaixu1987
2020-10-20 5:04 ` Dave Chinner [this message]
2020-10-27 18:47 ` Christoph Hellwig
2020-11-12 2:44 ` kaixuxia
2020-11-13 0:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020050423.GP7391@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox