From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Chandan Babu R <chandanrlinux@gmail.com>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com, hch@infradead.org
Subject: Re: [PATCH V7 08/14] xfs: Check for extent overflow when remapping an extent
Date: Mon, 26 Oct 2020 16:10:38 -0700 [thread overview]
Message-ID: <20201026231038.GA853509@magnolia> (raw)
In-Reply-To: <20201019064048.6591-9-chandanrlinux@gmail.com>
On Mon, Oct 19, 2020 at 12:10:42PM +0530, Chandan Babu R wrote:
> Remapping an extent involves unmapping the existing extent and mapping
> in the new extent. When unmapping, an extent containing the entire unmap
> range can be split into two extents,
> i.e. | Old extent | hole | Old extent |
> Hence extent count increases by 1.
>
> Mapping in the new extent into the destination file can increase the
> extent count by 1.
>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
Looks fine,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_reflink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
> index 4f0198f636ad..856fe755a5e9 100644
> --- a/fs/xfs/xfs_reflink.c
> +++ b/fs/xfs/xfs_reflink.c
> @@ -1006,6 +1006,7 @@ xfs_reflink_remap_extent(
> unsigned int resblks;
> bool smap_real;
> bool dmap_written = xfs_bmap_is_written_extent(dmap);
> + int iext_delta = 0;
> int nimaps;
> int error;
>
> @@ -1099,6 +1100,16 @@ xfs_reflink_remap_extent(
> goto out_cancel;
> }
>
> + if (smap_real)
> + ++iext_delta;
> +
> + if (dmap_written)
> + ++iext_delta;
> +
> + error = xfs_iext_count_may_overflow(ip, XFS_DATA_FORK, iext_delta);
> + if (error)
> + goto out_cancel;
> +
> if (smap_real) {
> /*
> * If the extent we're unmapping is backed by storage (written
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-26 23:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 6:40 [PATCH V7 00/14] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-10-19 6:40 ` [PATCH V7 01/14] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 02/14] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 03/14] xfs: Check for extent overflow when punching a hole Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 04/14] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-10-24 19:29 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 05/14] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-10-24 20:18 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 06/14] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-10-24 20:18 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 07/14] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-10-24 20:18 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 08/14] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-10-24 20:32 ` Allison Henderson
2020-10-26 23:10 ` Darrick J. Wong [this message]
2020-10-19 6:40 ` [PATCH V7 09/14] xfs: Check for extent overflow when swapping extents Chandan Babu R
2020-10-24 20:41 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 10/14] xfs: Introduce error injection to reduce maximum inode fork extent count Chandan Babu R
2020-10-24 20:44 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 11/14] xfs: Remove duplicate assert statement in xfs_bmap_btalloc() Chandan Babu R
2020-10-24 22:21 ` Allison Henderson
2020-10-26 23:11 ` Darrick J. Wong
2020-10-19 6:40 ` [PATCH V7 12/14] xfs: Compute bmap extent alignments in a separate function Chandan Babu R
2020-10-24 22:25 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 13/14] xfs: Process allocated extent " Chandan Babu R
2020-10-24 23:15 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 14/14] xfs: Introduce error injection to allocate only minlen size extents for files Chandan Babu R
2020-10-25 1:22 ` Allison Henderson
2020-10-26 3:23 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026231038.GA853509@magnolia \
--to=darrick.wong@oracle.com \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox