From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1.5/5 V2] mkfs: clarify valid "inherit" option values
Date: Tue, 27 Oct 2020 11:37:47 -0700 [thread overview]
Message-ID: <20201027183747.GA1061260@magnolia> (raw)
In-Reply-To: <04d65a53-00f9-527d-2b4c-c66b1799d2d4@sandeen.net>
On Tue, Oct 27, 2020 at 12:50:43PM -0500, Eric Sandeen wrote:
> Clarify which values are valid for the various *inherit= mkfs
> options.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: Keep the same "=value" as elsewhere in the manpage but still clarify
> what those values should be and what they do.
>
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 0a785874..10ceea30 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -378,31 +378,38 @@ without stripe geometry alignment even if the underlying storage device provides
> this information.
> .TP
> .BI rtinherit= value
> -If set, all inodes created by
> +If
> +.I value
> +is set to 1, all inodes created by
> .B mkfs.xfs
> -will be created with the realtime flag set.
> +will be created with the realtime flag set. Default is 0.
Nit: Start new sentences on a new line.
> Directories will pass on this flag to newly created regular files and
> directories.
> .TP
> .BI projinherit= value
> All inodes created by
> .B mkfs.xfs
> -will be assigned this project quota id.
> +will be assigned the project quota id provided in
Nit: Blank space at end of line.
> +.I value.
> Directories will pass on the project id to newly created regular files and
> directories.
> .TP
> .BI extszinherit= value
> All inodes created by
> .B mkfs.xfs
> -will have this extent size hint applied.
> +will have this
> +.I value
> +extent size hint applied.
> The value must be provided in units of filesystem blocks.
> Directories will pass on this hint to newly created regular files and
> directories.
> .TP
> .BI daxinherit= value
> -If set, all inodes created by
> +If
> +.I value
> +is set to 1, all inodes created by
> .B mkfs.xfs
> -will be created with the DAX flag set.
> +will be created with the DAX flag set. Default is 0.
The first nit again...
With /that/ fixed...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> Directories will pass on this flag to newly created regular files and
> directories.
> By default,
>
next prev parent reply other threads:[~2020-10-27 18:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:31 [PATCH 0/5] xfsprogs: fixes for 5.10 Darrick J. Wong
2020-10-26 23:31 ` [PATCH 1/5] mkfs: allow users to specify rtinherit=0 Darrick J. Wong
2020-10-27 5:35 ` Allison Henderson
2020-10-27 17:22 ` Eric Sandeen
2020-10-27 17:24 ` [PATCH 1.5/5] mkfs: clarify valid "inherit" option values Eric Sandeen
2020-10-27 17:40 ` Darrick J. Wong
2020-10-27 17:49 ` Eric Sandeen
2020-10-28 7:32 ` Christoph Hellwig
2020-10-27 17:50 ` [PATCH 1.5/5 V2] " Eric Sandeen
2020-10-27 18:37 ` Darrick J. Wong [this message]
2020-10-28 7:32 ` [PATCH 1/5] mkfs: allow users to specify rtinherit=0 Christoph Hellwig
2020-10-26 23:32 ` [PATCH 2/5] xfs: remove unnecessary parameter from scrub_scan_estimate_blocks Darrick J. Wong
2020-10-27 5:35 ` Allison Henderson
2020-10-27 15:33 ` Darrick J. Wong
2020-10-29 18:33 ` Darrick J. Wong
2020-10-29 18:38 ` Allison Henderson
2020-10-28 7:33 ` Christoph Hellwig
2020-10-26 23:32 ` [PATCH 3/5] xfs_db: report ranges of invalid rt blocks Darrick J. Wong
2020-10-27 5:35 ` Allison Henderson
2020-10-28 7:33 ` Christoph Hellwig
2020-10-26 23:32 ` [PATCH 4/5] xfs_repair: skip the rmap and refcount btree checks when the levels are garbage Darrick J. Wong
2020-10-27 5:35 ` Allison Henderson
2020-10-28 7:34 ` Christoph Hellwig
2020-10-26 23:32 ` [PATCH 5/5] xfs_repair: correctly detect partially written extents Darrick J. Wong
2020-10-27 5:52 ` Allison Henderson
2020-10-28 7:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027183747.GA1061260@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox