* [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
@ 2020-10-20 4:54 xiakaixu1987
2020-10-20 5:04 ` Dave Chinner
2020-10-27 18:47 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: xiakaixu1987 @ 2020-10-20 4:54 UTC (permalink / raw)
To: linux-xfs; +Cc: darrick.wong, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
fs/xfs/libxfs/xfs_format.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
index dd764da08f6f..40b6fa3b4e01 100644
--- a/fs/xfs/libxfs/xfs_format.h
+++ b/fs/xfs/libxfs/xfs_format.h
@@ -625,7 +625,6 @@ xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino)
#define XFS_B_TO_FSB(mp,b) \
((((uint64_t)(b)) + (mp)->m_blockmask) >> (mp)->m_sb.sb_blocklog)
#define XFS_B_TO_FSBT(mp,b) (((uint64_t)(b)) >> (mp)->m_sb.sb_blocklog)
-#define XFS_B_FSB_OFFSET(mp,b) ((b) & (mp)->m_blockmask)
/*
* Allocation group header
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
2020-10-20 4:54 [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro xiakaixu1987
@ 2020-10-20 5:04 ` Dave Chinner
2020-10-27 18:47 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2020-10-20 5:04 UTC (permalink / raw)
To: xiakaixu1987; +Cc: linux-xfs, darrick.wong, Kaixu Xia
On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> fs/xfs/libxfs/xfs_format.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index dd764da08f6f..40b6fa3b4e01 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -625,7 +625,6 @@ xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino)
> #define XFS_B_TO_FSB(mp,b) \
> ((((uint64_t)(b)) + (mp)->m_blockmask) >> (mp)->m_sb.sb_blocklog)
> #define XFS_B_TO_FSBT(mp,b) (((uint64_t)(b)) >> (mp)->m_sb.sb_blocklog)
> -#define XFS_B_FSB_OFFSET(mp,b) ((b) & (mp)->m_blockmask)
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
2020-10-20 4:54 [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro xiakaixu1987
2020-10-20 5:04 ` Dave Chinner
@ 2020-10-27 18:47 ` Christoph Hellwig
2020-11-12 2:44 ` kaixuxia
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2020-10-27 18:47 UTC (permalink / raw)
To: xiakaixu1987; +Cc: linux-xfs, darrick.wong, Kaixu Xia
On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
No callers in xfsprogs either.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
2020-10-27 18:47 ` Christoph Hellwig
@ 2020-11-12 2:44 ` kaixuxia
2020-11-13 0:21 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: kaixuxia @ 2020-11-12 2:44 UTC (permalink / raw)
To: darrick.wong; +Cc: Christoph Hellwig, linux-xfs, Kaixu Xia
On 2020/10/28 2:47, Christoph Hellwig wrote:
> On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
>
> No callers in xfsprogs either.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Hi Darrick,
There are some patches that have been reviewed but not been merged
into xfs for-next branch, I will reply to them.
Sorry for the noise:)
Thanks,
Kaixu
>
--
kaixuxia
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro
2020-11-12 2:44 ` kaixuxia
@ 2020-11-13 0:21 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2020-11-13 0:21 UTC (permalink / raw)
To: kaixuxia; +Cc: Christoph Hellwig, linux-xfs, Kaixu Xia
On Thu, Nov 12, 2020 at 10:44:25AM +0800, kaixuxia wrote:
>
>
> On 2020/10/28 2:47, Christoph Hellwig wrote:
> > On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote:
> >> From: Kaixu Xia <kaixuxia@tencent.com>
> >>
> >> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it.
> >
> > No callers in xfsprogs either.
> >
> > Looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Hi Darrick,
>
> There are some patches that have been reviewed but not been merged
> into xfs for-next branch, I will reply to them.
> Sorry for the noise:)
Yes. AFAICT none of them are critical 5.10 bugfixes so they're all
waiting for 5.11.
--D
> Thanks,
> Kaixu
> >
>
> --
> kaixuxia
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-13 0:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 4:54 [PATCH] xfs: remove the unused XFS_B_FSB_OFFSET macro xiakaixu1987
2020-10-20 5:04 ` Dave Chinner
2020-10-27 18:47 ` Christoph Hellwig
2020-11-12 2:44 ` kaixuxia
2020-11-13 0:21 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox