From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 9/9] common/populate: make sure _scratch_xfs_populate puts its files on the data device
Date: Wed, 28 Oct 2020 09:27:24 -0700 [thread overview]
Message-ID: <20201028162724.GC1061252@magnolia> (raw)
In-Reply-To: <20201028074446.GI2750@infradead.org>
On Wed, Oct 28, 2020 at 07:44:46AM +0000, Christoph Hellwig wrote:
> On Tue, Oct 27, 2020 at 12:02:27PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Make sure that _scratch_xfs_populate always installs its files on the
> > data device even if the test config selects rt by default.
>
> Can you explain why this is important (preferably also in a comment in
> the source)?
Ok. I'll change it to this:
# We cannot directly force the filesystem to create the metadata
# structures we want; we can only achieve this indirectly by carefully
# crafting files and a directory tree. Therefore, we must have exact
# control over the layout and device selection of all files created.
# Clear the rtinherit flag on the root directory so that files are
# always created on the data volume regardless of MKFS_OPTIONS.
# We can set the realtime flag when needed.
$XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT
--D
next prev parent reply other threads:[~2020-10-28 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 19:01 [PATCH 0/9] xfstests: random fixes Darrick J. Wong
2020-10-27 19:01 ` [PATCH 1/9] common: extract rt extent size for _get_file_block_size Darrick J. Wong
2020-10-28 7:41 ` Christoph Hellwig
2020-10-28 22:24 ` Darrick J. Wong
2020-10-27 19:01 ` [PATCH 2/9] xfs/520: disable external devices Darrick J. Wong
2020-10-28 7:41 ` Christoph Hellwig
2020-10-27 19:01 ` [PATCH 3/9] xfs/341: fix test when rextsize > 1 Darrick J. Wong
2020-10-28 7:41 ` Christoph Hellwig
2020-10-27 19:01 ` [PATCH 4/9] various: replace _get_block_size with _get_file_block_size when needed Darrick J. Wong
2020-10-28 7:42 ` Christoph Hellwig
2020-10-27 19:02 ` [PATCH 5/9] xfs/327: fix inode reflink flag checking Darrick J. Wong
2020-10-28 7:42 ` Christoph Hellwig
2020-10-27 19:02 ` [PATCH 6/9] xfs/27[26]: force realtime on or off as needed Darrick J. Wong
2020-10-28 7:43 ` Christoph Hellwig
2020-10-27 19:02 ` [PATCH 7/9] xfs/030: hide the btree levels check errors Darrick J. Wong
2020-10-28 7:43 ` Christoph Hellwig
2020-10-27 19:02 ` [PATCH 8/9] check: run tests in a systemd scope for mandatory test cleanup Darrick J. Wong
2020-10-28 7:44 ` Christoph Hellwig
2020-10-28 16:58 ` Darrick J. Wong
2020-10-29 1:04 ` Darrick J. Wong
2020-11-02 21:37 ` Darrick J. Wong
2020-10-27 19:02 ` [PATCH 9/9] common/populate: make sure _scratch_xfs_populate puts its files on the data device Darrick J. Wong
2020-10-28 7:44 ` Christoph Hellwig
2020-10-28 16:27 ` Darrick J. Wong [this message]
2020-11-08 10:05 ` [PATCH 0/9] xfstests: random fixes Eryu Guan
2020-11-08 17:23 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028162724.GC1061252@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox