Re: [PATCH 18/26] libxfs: propagate bigtime inode flag when allocating

Christoph Hellwig
2020-10-29T09:49:04Z

On Mon, Oct 26, 2020 at 04:36:03PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Ensure that we propagate the bigtime inode flag correctly when creating
> new inodes. There critical part here is to use the new_diflags2 field
> in the incore geometry just like we do in the kernel.
>
> We also modify xfs_flags2diflags2 to have the same behavior as the
> kernel. This isn't strictly needed here, but we aim to avoid letting
> userspace diverge from the kernel function when we can.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>