Re: [PATCH 08/26] xfs_logprint: refactor timestamp printing

Darrick J. Wong
2020-11-24T00:35:11Z

On Mon, Nov 23, 2020 at 02:14:27PM -0600, Eric Sandeen wrote:
> On 10/26/20 6:34 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Introduce type-specific printing functions to xfs_logprint to print an
> > xfs_timestamp instead of open-coding the timestamp decoding. This is
> > needed to stay ahead of changes that we're going to make to
> > xfs_timestamp_t in the following patches.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > logprint/log_misc.c | 18 ++++++++++++++++--
> > logprint/log_print_all.c | 3 +--
> > logprint/logprint.h | 2 ++
> > 3 files changed, 19 insertions(+), 4 deletions(-)
> >
>
> Just for the record, I decided to not take this one; the helper function
> with the somewhat vague "compact" arg at the callers doesnt' really seem
> worth it, I just open-coded this at the 2 callsites when I did the merge.

<nod> it was kind of questionable from the start :)

--D

> Thanks,
> -Eric