From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 7/7] xfs/122: fix test for xfs_attr_shortform_t conversion
Date: Thu, 29 Oct 2020 11:17:11 -0700 [thread overview]
Message-ID: <20201029181711.GS1061252@magnolia> (raw)
In-Reply-To: <CAOQ4uxgZ82k7y5QabzO0+2Xg6P0LDVf-ysyRvyMZeH6vm8os-g@mail.gmail.com>
On Thu, Oct 29, 2020 at 01:17:40PM +0200, Amir Goldstein wrote:
> On Wed, Oct 28, 2020 at 10:24 PM Darrick J. Wong
> <darrick.wong@oracle.com> wrote:
> >
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The typedef xfs_attr_shortform_t was converted to a struct in 5.10.
> > Update this test to pass.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/122.out | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> > diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> > index 45c42e59..cfe09c6d 100644
> > --- a/tests/xfs/122.out
> > +++ b/tests/xfs/122.out
> > @@ -62,6 +62,7 @@ sizeof(struct xfs_agfl) = 36
> > sizeof(struct xfs_attr3_leaf_hdr) = 80
> > sizeof(struct xfs_attr3_leafblock) = 88
> > sizeof(struct xfs_attr3_rmt_hdr) = 56
> > +sizeof(struct xfs_attr_shortform) = 8
> > sizeof(struct xfs_btree_block) = 72
> > sizeof(struct xfs_btree_block_lhdr) = 64
> > sizeof(struct xfs_btree_block_shdr) = 48
> >
>
> Maybe remove comment
>
> # missing:
> # xfs_attr_shortform_t
>
> While at it.
I'll do that, thanks!
--D
> Thanks,
> Amir.
next prev parent reply other threads:[~2020-10-29 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 19:02 [PATCH 0/7] various: test xfs things fixed in 5.10 Darrick J. Wong
2020-10-27 19:02 ` [PATCH 1/7] xfs: test fallocate ops when rt extent size is and isn't a power of 2 Darrick J. Wong
2020-10-29 6:13 ` Chandan Babu R
2020-10-27 19:02 ` [PATCH 2/7] xfs: test regression in xfs_bmap_validate_extent Darrick J. Wong
2020-10-29 6:45 ` Chandan Babu R
2020-10-27 19:02 ` [PATCH 3/7] generic: test reflink and copy_file_range behavior with O_SYNC and FS_XFLAG_SYNC files Darrick J. Wong
2020-10-29 9:10 ` Chandan Babu R
2020-10-27 19:02 ` [PATCH 4/7] xfs: test rtalloc alignment and math errors Darrick J. Wong
2020-10-27 19:03 ` [PATCH 5/7] xfs: test mkfs min log size calculation w/ rt volumes Darrick J. Wong
2020-10-27 19:03 ` [PATCH 6/7] xfs: test quota softlimit warning functionality Darrick J. Wong
2020-10-27 19:03 ` [PATCH 7/7] xfs/122: fix test for xfs_attr_shortform_t conversion Darrick J. Wong
2020-10-29 10:12 ` Chandan Babu R
2020-10-29 11:17 ` Amir Goldstein
2020-10-29 18:17 ` Darrick J. Wong [this message]
2020-10-27 21:32 ` [PATCH 0/7] various: test xfs things fixed in 5.10 Theodore Y. Ts'o
2020-10-27 22:27 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-11-11 0:43 Darrick J. Wong
2020-11-11 0:44 ` [PATCH 7/7] xfs/122: fix test for xfs_attr_shortform_t conversion Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029181711.GS1061252@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox