From: Chandan Babu R <chandanrlinux@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
darrick.wong@oracle.com, david@fromorbit.com, hch@infradead.org,
allison.henderson@oracle.com
Subject: [PATCH V10 11/14] xfs: Remove duplicate assert statement in xfs_bmap_btalloc()
Date: Tue, 3 Nov 2020 20:36:39 +0530 [thread overview]
Message-ID: <20201103150642.2032284-12-chandanrlinux@gmail.com> (raw)
In-Reply-To: <20201103150642.2032284-1-chandanrlinux@gmail.com>
The check for verifying if the allocated extent is from an AG whose
index is greater than or equal to that of tp->t_firstblock is already
done a couple of statements earlier in the same function. Hence this
commit removes the redundant assert statement.
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
fs/xfs/libxfs/xfs_bmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 505358839d2f..64c4d0e384a5 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -3699,7 +3699,6 @@ xfs_bmap_btalloc(
ap->blkno = args.fsbno;
if (ap->tp->t_firstblock == NULLFSBLOCK)
ap->tp->t_firstblock = args.fsbno;
- ASSERT(nullfb || fb_agno <= args.agno);
ap->length = args.len;
/*
* If the extent size hint is active, we tried to round the
--
2.28.0
next prev parent reply other threads:[~2020-11-03 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:06 [PATCH V10 00/14] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 01/14] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 02/14] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 03/14] xfs: Check for extent overflow when punching a hole Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 04/14] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 05/14] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 06/14] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 07/14] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 08/14] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 09/14] xfs: Check for extent overflow when swapping extents Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 10/14] xfs: Introduce error injection to reduce maximum inode fork extent count Chandan Babu R
2020-11-03 15:06 ` Chandan Babu R [this message]
2020-11-03 15:06 ` [PATCH V10 12/14] xfs: Compute bmap extent alignments in a separate function Chandan Babu R
2020-11-03 19:51 ` Darrick J. Wong
2020-11-04 3:21 ` Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 13/14] xfs: Process allocated extent " Chandan Babu R
2020-11-03 15:06 ` [PATCH V10 14/14] xfs: Introduce error injection to allocate only minlen size extents for files Chandan Babu R
2020-11-03 19:56 ` Darrick J. Wong
2020-11-04 3:22 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103150642.2032284-12-chandanrlinux@gmail.com \
--to=chandanrlinux@gmail.com \
--cc=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox