From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH 2/3] xfs: set the unwritten bit in rmap lookup flags in xchk_bmap_get_rmapextents
Date: Tue, 10 Nov 2020 18:33:54 +0000 [thread overview]
Message-ID: <20201110183354.GB9418@infradead.org> (raw)
In-Reply-To: <160494584199.772693.777818995688769739.stgit@magnolia>
On Mon, Nov 09, 2020 at 10:17:22AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When the bmbt scrubber is looking up rmap extents, we need to set the
> extent flags from the bmbt record fully. This will matter once we fix
> the rmap btree comparison functions to check those flags correctly.
>
> Fixes: d852657ccfc0 ("xfs: cross-reference reverse-mapping btree")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-11-10 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 18:17 [PATCH 0/3] xfs: fix serious bugs in rmap key comparison Darrick J. Wong
2020-11-09 18:17 ` [PATCH 1/3] xfs: fix flags argument to rmap lookup when converting shared file rmaps Darrick J. Wong
2020-11-10 18:33 ` Christoph Hellwig
2020-11-09 18:17 ` [PATCH 2/3] xfs: set the unwritten bit in rmap lookup flags in xchk_bmap_get_rmapextents Darrick J. Wong
2020-11-10 18:33 ` Christoph Hellwig [this message]
2020-11-09 18:17 ` [PATCH 3/3] xfs: fix rmap key and record comparison functions Darrick J. Wong
2020-11-10 18:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110183354.GB9418@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox