From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/9] mkfs: don't pass on extent size inherit flags when extent size is zero
Date: Tue, 10 Nov 2020 18:37:06 +0000 [thread overview]
Message-ID: <20201110183706.GG9418@infradead.org> (raw)
In-Reply-To: <160503140288.1201232.14448155271122385848.stgit@magnolia>
On Tue, Nov 10, 2020 at 10:03:22AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> If the caller passes in an extent size hint of zero, clear the inherit
> flags because a hint value of zero is treated as not a hint.
>
> Otherwise, you get stupid stuff like:
> $ mkfs.xfs -d cowextsize=0 /tmp/a.img -f
> illegal CoW extent size hint 0, must be less than 9600.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-11-10 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 18:03 [PATCH v2 0/9] xfsprogs: fixes for 5.10 Darrick J. Wong
2020-11-10 18:03 ` [PATCH 1/9] mkfs: allow users to specify rtinherit=0 Darrick J. Wong
2020-11-10 18:03 ` [PATCH 2/9] mkfs: clarify valid "inherit" option values Darrick J. Wong
2020-11-10 18:36 ` Christoph Hellwig
2020-11-10 18:03 ` [PATCH 3/9] mkfs: don't pass on extent size inherit flags when extent size is zero Darrick J. Wong
2020-11-10 18:37 ` Christoph Hellwig [this message]
2020-11-10 18:03 ` [PATCH 4/9] xfs: remove unnecessary parameter from scrub_scan_estimate_blocks Darrick J. Wong
2020-11-10 18:03 ` [PATCH 5/9] xfs_db: report ranges of invalid rt blocks Darrick J. Wong
2020-11-10 18:03 ` [PATCH 6/9] xfs_repair: skip the rmap and refcount btree checks when the levels are garbage Darrick J. Wong
2020-11-10 18:03 ` [PATCH 7/9] xfs_repair: correctly detect partially written extents Darrick J. Wong
2020-11-10 18:03 ` [PATCH 8/9] xfs_repair: directly compare refcount records Darrick J. Wong
2020-11-10 18:37 ` Christoph Hellwig
2020-11-10 18:04 ` [PATCH 9/9] libxfs-apply: don't add duplicate headers Darrick J. Wong
2020-11-10 18:37 ` Christoph Hellwig
2020-11-23 20:30 ` Eric Sandeen
2020-11-24 0:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110183706.GG9418@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox