Re: [PATCH v13 07/10] xfs: Add feature bit XFS_SB_FEAT_INCOMPAT_LOG_DELATTR

Allison Henderson
2020-11-13T01:27:24Z

On 11/10/20 1:10 PM, Darrick J. Wong wrote:
> On Thu, Oct 22, 2020 at 11:34:32PM -0700, Allison Henderson wrote:
>> This patch adds a new feature bit XFS_SB_FEAT_INCOMPAT_LOG_DELATTR which
>> can be used to control turning on/off delayed attributes
>>
>> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
>> ---
>> fs/xfs/libxfs/xfs_format.h | 8 ++++++--
>> fs/xfs/libxfs/xfs_fs.h | 1 +
>> fs/xfs/libxfs/xfs_sb.c | 2 ++
>> fs/xfs/xfs_super.c | 3 +++
>> 4 files changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
>> index d419c34..18b41a7 100644
>> --- a/fs/xfs/libxfs/xfs_format.h
>> +++ b/fs/xfs/libxfs/xfs_format.h
>> @@ -483,7 +483,9 @@ xfs_sb_has_incompat_feature(
>> return (sbp->sb_features_incompat & feature) != 0;
>> }
>>
>> -#define XFS_SB_FEAT_INCOMPAT_LOG_ALL 0
>> +#define XFS_SB_FEAT_INCOMPAT_LOG_DELATTR (1 << 0) /* Delayed Attributes */
>> +#define XFS_SB_FEAT_INCOMPAT_LOG_ALL \
>> + (XFS_SB_FEAT_INCOMPAT_LOG_DELATTR)
>> #define XFS_SB_FEAT_INCOMPAT_LOG_UNKNOWN ~XFS_SB_FEAT_INCOMPAT_LOG_ALL
>> static inline bool
>> xfs_sb_has_incompat_log_feature(
>> @@ -586,7 +588,9 @@ static inline bool xfs_sb_version_hasinobtcounts(struct xfs_sb *sbp)
>>
>> static inline bool xfs_sb_version_hasdelattr(struct xfs_sb *sbp)
>> {
>> - return false;
>> + return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5 &&
>> + (sbp->sb_features_log_incompat &
>> + XFS_SB_FEAT_INCOMPAT_LOG_DELATTR));
>
> This change and the EXPERIMENTAL warning should go in whichever patch
> defines xfs_sb_version_hasdelattr.

Sure, will move this to patch 5

>
>> }
>>
>> /*
>> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
>> index 2a2e3cf..f703d95 100644
>> --- a/fs/xfs/libxfs/xfs_fs.h
>> +++ b/fs/xfs/libxfs/xfs_fs.h
>> @@ -250,6 +250,7 @@ typedef struct xfs_fsop_resblks {
>> #define XFS_FSOP_GEOM_FLAGS_RMAPBT (1 << 19) /* reverse mapping btree */
>> #define XFS_FSOP_GEOM_FLAGS_REFLINK (1 << 20) /* files can share blocks */
>> #define XFS_FSOP_GEOM_FLAGS_BIGTIME (1 << 21) /* 64-bit nsec timestamps */
>> +#define XFS_FSOP_GEOM_FLAGS_DELATTR (1 << 22) /* delayed attributes */
>>
>> /*
>> * Minimum and maximum sizes need for growth checks.
>> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
>> index 5aeafa5..a0ec327 100644
>> --- a/fs/xfs/libxfs/xfs_sb.c
>> +++ b/fs/xfs/libxfs/xfs_sb.c
>> @@ -1168,6 +1168,8 @@ xfs_fs_geometry(
>> geo->flags |= XFS_FSOP_GEOM_FLAGS_REFLINK;
>> if (xfs_sb_version_hasbigtime(sbp))
>> geo->flags |= XFS_FSOP_GEOM_FLAGS_BIGTIME;
>> + if (xfs_sb_version_hasdelattr(sbp))
>> + geo->flags |= XFS_FSOP_GEOM_FLAGS_DELATTR;
>
> These changes to the geometry ioctl should be a separate patch.
>
> IOWs, the only change in this patch should be adding
> XFS_SB_FEAT_INCOMPAT_LOG_DELATTR to the _ALL #define.
Ok, will break out.

Allison

>
> --D
>
>> if (xfs_sb_version_hassector(sbp))
>> geo->logsectsize = sbp->sb_logsectsize;
>> else
>> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
>> index d1b5f2d..bb85884 100644
>> --- a/fs/xfs/xfs_super.c
>> +++ b/fs/xfs/xfs_super.c
>> @@ -1580,6 +1580,9 @@ xfs_fc_fill_super(
>> if (xfs_sb_version_hasinobtcounts(&mp->m_sb))
>> xfs_warn(mp,
>> "EXPERIMENTAL inode btree counters feature in use. Use at your own risk!");
>> + if (xfs_sb_version_hasdelattr(&mp->m_sb))
>> + xfs_alert(mp,
>> + "EXPERIMENTAL delayed attrs feature enabled. Use at your own risk!");
>>
>> error = xfs_mountfs(mp);
>> if (error)
>> --
>> 2.7.4
>>