From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Gao Xiang <hsiangkao@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: kill ialloced in xfs_dialloc()
Date: Tue, 1 Dec 2020 08:55:11 -0800 [thread overview]
Message-ID: <20201201165511.GE143045@magnolia> (raw)
In-Reply-To: <20201201102100.GF12730@infradead.org>
On Tue, Dec 01, 2020 at 10:21:00AM +0000, Christoph Hellwig wrote:
> On Tue, Nov 24, 2020 at 11:51:29PM +0800, Gao Xiang wrote:
> > It's enough to just use return code, and get rid of an argument.
> >
> > Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> > ---
> > fs/xfs/libxfs/xfs_ialloc.c | 22 ++++++++++------------
> > 1 file changed, 10 insertions(+), 12 deletions(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> > index 45cf7e55f5ee..5c8b0210aad3 100644
> > --- a/fs/xfs/libxfs/xfs_ialloc.c
> > +++ b/fs/xfs/libxfs/xfs_ialloc.c
> > @@ -607,13 +607,14 @@ xfs_inobt_insert_sprec(
> >
> > /*
> > * Allocate new inodes in the allocation group specified by agbp.
> > - * Return 0 for success, else error code.
> > + * Return 0 for successfully allocating some inodes in this AG;
> > + * 1 for skipping to allocating in the next AG;
>
> s/for/when/ for both lines I think.
>
> > + * < 0 for error code.
>
> and < 0 for errors here maybe. But I'm not a native speaker either.
"Returns 0 if inodes were allocated in this AG; 1 if there was no space
in this AG; or the usual negative error code." ?
--D
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-12-01 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:51 [PATCH 1/3] xfs: convert noroom, okalloc in xfs_dialloc() to bool Gao Xiang
2020-11-24 15:51 ` [PATCH 2/3] xfs: kill ialloced in xfs_dialloc() Gao Xiang
2020-12-01 10:21 ` Christoph Hellwig
2020-12-01 11:55 ` Gao Xiang
2020-12-01 16:55 ` Darrick J. Wong [this message]
2020-12-01 23:50 ` Gao Xiang
2020-12-01 17:04 ` Darrick J. Wong
2020-12-01 23:59 ` Gao Xiang
2020-11-24 15:51 ` [PATCH 3/3] xfs: clean up xfs_dialloc() by introducing __xfs_dialloc() Gao Xiang
2020-11-24 22:16 ` Dave Chinner
2020-11-24 23:14 ` Gao Xiang
2020-12-01 10:19 ` [PATCH 1/3] xfs: convert noroom, okalloc in xfs_dialloc() to bool Christoph Hellwig
2020-12-01 16:56 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201165511.GE143045@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=hsiangkao@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox