From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: convert noroom, okalloc in xfs_dialloc() to bool
Date: Tue, 1 Dec 2020 08:56:36 -0800 [thread overview]
Message-ID: <20201201165636.GF143045@magnolia> (raw)
In-Reply-To: <20201124155130.40848-1-hsiangkao@redhat.com>
On Tue, Nov 24, 2020 at 11:51:28PM +0800, Gao Xiang wrote:
> Boolean is preferred for such use.
>
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
Looks simple enough,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_ialloc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> index 974e71bc4a3a..45cf7e55f5ee 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.c
> +++ b/fs/xfs/libxfs/xfs_ialloc.c
> @@ -1716,11 +1716,11 @@ xfs_dialloc(
> xfs_agnumber_t agno;
> int error;
> int ialloced;
> - int noroom = 0;
> + bool noroom = false;
> xfs_agnumber_t start_agno;
> struct xfs_perag *pag;
> struct xfs_ino_geometry *igeo = M_IGEO(mp);
> - int okalloc = 1;
> + bool okalloc = true;
>
> if (*IO_agbp) {
> /*
> @@ -1753,8 +1753,8 @@ xfs_dialloc(
> if (igeo->maxicount &&
> percpu_counter_read_positive(&mp->m_icount) + igeo->ialloc_inos
> > igeo->maxicount) {
> - noroom = 1;
> - okalloc = 0;
> + noroom = true;
> + okalloc = false;
> }
>
> /*
> --
> 2.18.4
>
prev parent reply other threads:[~2020-12-01 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:51 [PATCH 1/3] xfs: convert noroom, okalloc in xfs_dialloc() to bool Gao Xiang
2020-11-24 15:51 ` [PATCH 2/3] xfs: kill ialloced in xfs_dialloc() Gao Xiang
2020-12-01 10:21 ` Christoph Hellwig
2020-12-01 11:55 ` Gao Xiang
2020-12-01 16:55 ` Darrick J. Wong
2020-12-01 23:50 ` Gao Xiang
2020-12-01 17:04 ` Darrick J. Wong
2020-12-01 23:59 ` Gao Xiang
2020-11-24 15:51 ` [PATCH 3/3] xfs: clean up xfs_dialloc() by introducing __xfs_dialloc() Gao Xiang
2020-11-24 22:16 ` Dave Chinner
2020-11-24 23:14 ` Gao Xiang
2020-12-01 10:19 ` [PATCH 1/3] xfs: convert noroom, okalloc in xfs_dialloc() to bool Christoph Hellwig
2020-12-01 16:56 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201165636.GF143045@magnolia \
--to=darrick.wong@oracle.com \
--cc=hsiangkao@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox