From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A59C433FE for ; Thu, 3 Dec 2020 20:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D7F3221F5 for ; Thu, 3 Dec 2020 20:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbgLCUdI (ORCPT ); Thu, 3 Dec 2020 15:33:08 -0500 Received: from mail110.syd.optusnet.com.au ([211.29.132.97]:33252 "EHLO mail110.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgLCUdI (ORCPT ); Thu, 3 Dec 2020 15:33:08 -0500 Received: from dread.disaster.area (pa49-179-6-140.pa.nsw.optusnet.com.au [49.179.6.140]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id C45B210C9C4; Fri, 4 Dec 2020 07:32:25 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kkvH7-000B8z-Aa; Fri, 04 Dec 2020 07:32:25 +1100 Date: Fri, 4 Dec 2020 07:32:25 +1100 From: Dave Chinner To: Gao Xiang Cc: linux-xfs@vger.kernel.org, "Darrick J. Wong" , Christoph Hellwig Subject: Re: [PATCH v2 1/6] xfs: convert noroom, okalloc in xfs_dialloc() to bool Message-ID: <20201203203225.GC3913616@dread.disaster.area> References: <20201203161028.1900929-1-hsiangkao@redhat.com> <20201203161028.1900929-2-hsiangkao@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203161028.1900929-2-hsiangkao@redhat.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=F8MpiZpN c=1 sm=1 tr=0 cx=a_idp_d a=uDU3YIYVKEaHT0eX+MXYOQ==:117 a=uDU3YIYVKEaHT0eX+MXYOQ==:17 a=kj9zAlcOel0A:10 a=zTNgK-yGK50A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JVVwYj4mlE_xCAclwfcA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Dec 04, 2020 at 12:10:23AM +0800, Gao Xiang wrote: > Boolean is preferred for such use. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong > Signed-off-by: Gao Xiang > --- > fs/xfs/libxfs/xfs_ialloc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) looks good, Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com