From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 5/3] xfs_repair: clear the needsrepair flag
Date: Thu, 3 Dec 2020 17:13:53 -0800 [thread overview]
Message-ID: <20201204011353.GD629293@magnolia> (raw)
In-Reply-To: <160679383892.447856.12907477074923729733.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Clear the needsrepair flag, since it's used to prevent mounting of an
inconsistent filesystem.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
| 11 +++++++++++
1 file changed, 11 insertions(+)
--git a/repair/agheader.c b/repair/agheader.c
index f28d8a7bb0de..53f541d4a53a 100644
--- a/repair/agheader.c
+++ b/repair/agheader.c
@@ -452,6 +452,17 @@ secondary_sb_whack(
rval |= XR_AG_SB_SEC;
}
+ if (xfs_sb_version_needsrepair(sb)) {
+ if (!no_modify)
+ sb->sb_features_incompat &=
+ ~XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR;
+ if (!do_bzero) {
+ rval |= XR_AG_SB;
+ do_warn(_("needsrepair flag set in sb %d\n"), i);
+ } else
+ rval |= XR_AG_SB_SEC;
+ }
+
return(rval);
}
prev parent reply other threads:[~2020-12-04 1:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:37 [PATCH 0/3] xfs: add the ability to flag a fs for repair Darrick J. Wong
2020-12-01 3:37 ` [PATCH 1/3] xfs: move kernel-specific superblock validation out of libxfs Darrick J. Wong
2020-12-01 16:17 ` Brian Foster
2020-12-04 20:35 ` Eric Sandeen
2020-12-04 21:12 ` Darrick J. Wong
2020-12-04 21:46 ` Eric Sandeen
2020-12-04 23:02 ` Darrick J. Wong
2020-12-04 23:29 ` Dave Chinner
2020-12-01 3:37 ` [PATCH 2/3] xfs: define a new "needrepair" feature Darrick J. Wong
2020-12-01 16:18 ` Brian Foster
2020-12-01 16:25 ` Darrick J. Wong
2020-12-01 17:09 ` Brian Foster
2020-12-04 20:07 ` Eric Sandeen
2020-12-04 21:36 ` Darrick J. Wong
2020-12-01 3:37 ` [PATCH 3/3] xfs: enable the needsrepair feature Darrick J. Wong
2020-12-01 16:18 ` Brian Foster
2020-12-04 20:35 ` Eric Sandeen
2020-12-04 1:13 ` [PATCH 4/3] xfs_db: support the needsrepair feature flag in the version command Darrick J. Wong
2020-12-04 20:32 ` Eric Sandeen
2020-12-04 21:09 ` Darrick J. Wong
2020-12-04 21:16 ` Eric Sandeen
2020-12-04 1:13 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204011353.GD629293@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox