Re: [PATCH 2/3] xfs: fix parent pointer scrubber bailing out on unallocated inodes

Christoph Hellwig
2020-12-04T10:10:25Z

On Thu, Dec 03, 2020 at 05:12:56PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> xfs_iget can return -ENOENT for a file that the inobt thinks is
> allocated but has zeroed mode. This currently causes scrub to exit
> with an operational error instead of flagging this as a corruption. The
> end result is that scrub mistakenly reports the ENOENT to the user
> instead of "directory parent pointer corrupt" like we do for EINVAL.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>