From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: scrub should mark a directory corrupt if any entries cannot be iget'd
Date: Fri, 4 Dec 2020 10:11:01 +0000 [thread overview]
Message-ID: <20201204101101.GC1734@infradead.org> (raw)
In-Reply-To: <160704438289.736504.15952269053640029711.stgit@magnolia>
On Thu, Dec 03, 2020 at 05:13:02PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> It's possible that xfs_iget can return EINVAL for inodes that the inobt
> thinks are free, or ENOENT for inodes that look free. If this is the
> case, mark the directory corrupt immediately when we check ftype. Note
> that we already check the ftype of the '.' and '..' entries, so we
> can skip the iget part since we already know the inode type for '.' and
> we have a separate parent pointer scrubber for '..'.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I wonder if we need the EINVAL vs ENOENT distinction to start
with or if we could return a single coherent error code from iget.
prev parent reply other threads:[~2020-12-04 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 1:12 [PATCH 0/3] xfs: random fixes for 5.11 Darrick J. Wong
2020-12-04 1:12 ` [PATCH 1/3] xfs: detect overflows in bmbt records Darrick J. Wong
2020-12-04 10:09 ` Christoph Hellwig
2020-12-04 1:12 ` [PATCH 2/3] xfs: fix parent pointer scrubber bailing out on unallocated inodes Darrick J. Wong
2020-12-04 10:09 ` Christoph Hellwig
2020-12-04 1:13 ` [PATCH 3/3] xfs: scrub should mark a directory corrupt if any entries cannot be iget'd Darrick J. Wong
2020-12-04 10:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204101101.GC1734@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox