From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items
Date: Fri, 4 Dec 2020 11:54:13 -0800 [thread overview]
Message-ID: <20201204195413.GE629293@magnolia> (raw)
In-Reply-To: <20201204135638.GD1404170@bfoster>
On Fri, Dec 04, 2020 at 08:56:38AM -0500, Brian Foster wrote:
> On Thu, Dec 03, 2020 at 05:11:46PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The code that validates recovered bmap intent items is kind of a mess --
> > it doesn't use the standard xfs type validators, and it doesn't check
> > for things that it should. Fix the validator function to use the
> > standard validation helpers and look for more types of obvious errors.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > fs/xfs/xfs_bmap_item.c | 26 +++++++++++++-------------
> > 1 file changed, 13 insertions(+), 13 deletions(-)
> >
> >
> > diff --git a/fs/xfs/xfs_bmap_item.c b/fs/xfs/xfs_bmap_item.c
> > index 555453d0e080..78346d47564b 100644
> > --- a/fs/xfs/xfs_bmap_item.c
> > +++ b/fs/xfs/xfs_bmap_item.c
> ...
> > @@ -448,13 +442,19 @@ xfs_bui_validate(
> > return false;
> > }
> >
> > - if (startblock_fsb == 0 ||
> > - bmap->me_len == 0 ||
> > - inode_fsb == 0 ||
> > - startblock_fsb >= mp->m_sb.sb_dblocks ||
> > - bmap->me_len >= mp->m_sb.sb_agblocks ||
> > - inode_fsb >= mp->m_sb.sb_dblocks ||
> > - (bmap->me_flags & ~XFS_BMAP_EXTENT_FLAGS))
> > + if (!xfs_verify_ino(mp, bmap->me_owner))
> > + return false;
> > +
> > + if (bmap->me_startoff + bmap->me_len <= bmap->me_startoff)
> > + return false;
> > +
> > + if (bmap->me_startblock + bmap->me_len <= bmap->me_startblock)
> > + return false;
> > +
> > + if (!xfs_verify_fsbno(mp, bmap->me_startblock))
> > + return false;
> > +
> > + if (!xfs_verify_fsbno(mp, bmap->me_startblock + bmap->me_len - 1))
> > return false;
>
> If this is going to be a common pattern, I wonder if an
> xfs_verify_extent() or some such helper that covers the above range
> checks would be helpful. Regardless:
Yes. I'll add a new patch to refactor all the bmap extent validators at
the end.
--D
> Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> >
> > return true;
> >
>
next prev parent reply other threads:[~2020-12-04 19:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 1:11 [PATCH v2 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-04 1:11 ` [PATCH 01/10] xfs: hoist recovered bmap intent checks out of xfs_bui_item_recover Darrick J. Wong
2020-12-04 13:55 ` Brian Foster
2020-12-04 1:11 ` [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Darrick J. Wong
2020-12-04 13:56 ` Brian Foster
2020-12-04 19:54 ` Darrick J. Wong [this message]
2020-12-04 1:11 ` [PATCH 03/10] xfs: hoist recovered rmap intent checks out of xfs_rui_item_recover Darrick J. Wong
2020-12-04 13:59 ` Brian Foster
2020-12-04 1:12 ` [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items Darrick J. Wong
2020-12-04 13:59 ` Brian Foster
2020-12-04 1:12 ` [PATCH 05/10] xfs: hoist recovered refcount intent checks out of xfs_cui_item_recover Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 06/10] xfs: improve the code that checks recovered refcount intent items Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 07/10] xfs: hoist recovered extent-free intent checks out of xfs_efi_item_recover Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 08/10] xfs: improve the code that checks recovered extent-free intent items Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 09/10] xfs: validate feature support when recovering rmap/refcount/bmap intents Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-06 23:08 ` Darrick J. Wong
2020-12-07 14:02 ` Brian Foster
2020-12-07 16:50 ` Darrick J. Wong
2020-12-04 1:12 ` [PATCH 10/10] xfs: trace log intent item recovery failures Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 19:57 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-12-06 23:09 [PATCH v3 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-06 23:09 ` [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Darrick J. Wong
2020-12-01 3:37 [PATCH 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-01 3:37 ` [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Darrick J. Wong
2020-12-01 10:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204195413.GE629293@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox