From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708FBC4361B for ; Sun, 6 Dec 2020 23:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43F3A22D08 for ; Sun, 6 Dec 2020 23:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728356AbgLFXr6 (ORCPT ); Sun, 6 Dec 2020 18:47:58 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:56260 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgLFXr6 (ORCPT ); Sun, 6 Dec 2020 18:47:58 -0500 Received: from dread.disaster.area (pa49-179-6-140.pa.nsw.optusnet.com.au [49.179.6.140]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 46D4558D809; Mon, 7 Dec 2020 10:47:16 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1km3kJ-001GGp-NG; Mon, 07 Dec 2020 10:47:15 +1100 Date: Mon, 7 Dec 2020 10:47:15 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, bfoster@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/3] xfs: move kernel-specific superblock validation out of libxfs Message-ID: <20201206234715.GL3913616@dread.disaster.area> References: <160729616025.1606994.13590463307385382944.stgit@magnolia> <160729616682.1606994.13360186718552701085.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <160729616682.1606994.13360186718552701085.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=F8MpiZpN c=1 sm=1 tr=0 cx=a_idp_d a=uDU3YIYVKEaHT0eX+MXYOQ==:117 a=uDU3YIYVKEaHT0eX+MXYOQ==:17 a=kj9zAlcOel0A:10 a=zTNgK-yGK50A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=BedopNC3CYm7WClzyZ0A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Dec 06, 2020 at 03:09:26PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > A couple of the superblock validation checks apply only to the kernel, > so move them to xfs_fc_fill_super before we add the needsrepair "feature", > which will prevent the kernel (but not xfsprogs) from mounting the > filesystem. This also reduces the diff between kernel and userspace > libxfs. looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com