Re: [PATCH v3 5/6] xfs: spilt xfs_dialloc() into 2 functions

Christoph Hellwig
2020-12-07T13:57:25Z

> if (pag->pagi_freecount) {
> xfs_perag_put(pag);
> + *IO_agbp = agbp;
> + return 0;

I think assigning *IO_agbp would benefit from a little consolidation.
Set it to NULL in the normal unsuccessful return, and add a found_ag
label that assigns agbp and returns 0.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>