Re: [PATCH v3 4/6] xfs: move xfs_dialloc_roll() into xfs_dialloc()

Gao Xiang
2020-12-07T14:22:22Z

On Mon, Dec 07, 2020 at 02:53:36PM +0100, Christoph Hellwig wrote:
> >
> > if (ialloced) {
> > /*
> > + * We successfully allocated some inodes, roll the
> > + * transaction so they can allocate one of the free
> > + * inodes we just prepared for them.
>
> Maybe:
>
> /*
> * We successfully allocated space for an inode cluster
> * in this AG. Roll the transaction so that we can
> * allocate one of the new inodes.
> */

Okay, will update.

Thanks,
Gao Xiang

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>