Re: [PATCH v3 3/6] xfs: move on-disk inode allocation out of xfs_ialloc()

Christoph Hellwig
2020-12-07T14:22:24Z

On Mon, Dec 07, 2020 at 10:19:48PM +0800, Gao Xiang wrote:
> > Maybe spell out parent_inode? pino reminds of some of the weird Windows
> > code that start all variable names for pointers with a "p".
>
> Ok, yet pino is somewhat common, as I saw it in f2fs and jffs2 before.
> I know you mean 'Hungarian naming conventions'.
>
> If you don't like pino. How about parent_ino? since parent_inode occurs me
> about "struct inode *" or something like this (a pointer around some inode),
> rather than an inode number.

Yeah, parent_ino is what I mean to suggest anyway, sorry for the typo.