From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xiakaixu1987@gmail.com
Cc: fstests@vger.kernel.org, guaneryu@gmail.com,
linux-xfs@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce
Date: Mon, 7 Dec 2020 09:01:04 -0800 [thread overview]
Message-ID: <20201207170104.GO629293@magnolia> (raw)
In-Reply-To: <1607341265-24200-1-git-send-email-kaixuxia@tencent.com>
On Mon, Dec 07, 2020 at 07:41:05PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The mount options uqnoenforce and qnoenforce no longer cause 'usrquota'
> to be emitted in /proc/mounts, so there is a regression in xfs/513. Fix
> it by using proper output option uqnoenforce.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Seems reasonable once the upstream change gets a commit id so that we
can point people at how to fix this new regression.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/513 | 4 ++--
> tests/xfs/513.out | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/xfs/513 b/tests/xfs/513
> index dfb25a8b..9045dbb5 100755
> --- a/tests/xfs/513
> +++ b/tests/xfs/513
> @@ -302,8 +302,8 @@ do_test "" pass "usrquota" "false"
> do_test "-o uquota" pass "usrquota" "true"
> do_test "-o usrquota" pass "usrquota" "true"
> do_test "-o quota" pass "usrquota" "true"
> -do_test "-o uqnoenforce" pass "usrquota" "true"
> -do_test "-o qnoenforce" pass "usrquota" "true"
> +do_test "-o uqnoenforce" pass "uqnoenforce" "true"
> +do_test "-o qnoenforce" pass "uqnoenforce" "true"
>
> # Test gquota/grpquota/gqnoenforce
> do_test "" pass "grpquota" "false"
> diff --git a/tests/xfs/513.out b/tests/xfs/513.out
> index 6681a7e8..eec8155d 100644
> --- a/tests/xfs/513.out
> +++ b/tests/xfs/513.out
> @@ -76,8 +76,8 @@ TEST: "" "pass" "usrquota" "false"
> TEST: "-o uquota" "pass" "usrquota" "true"
> TEST: "-o usrquota" "pass" "usrquota" "true"
> TEST: "-o quota" "pass" "usrquota" "true"
> -TEST: "-o uqnoenforce" "pass" "usrquota" "true"
> -TEST: "-o qnoenforce" "pass" "usrquota" "true"
> +TEST: "-o uqnoenforce" "pass" "uqnoenforce" "true"
> +TEST: "-o qnoenforce" "pass" "uqnoenforce" "true"
> TEST: "" "pass" "grpquota" "false"
> TEST: "-o gquota" "pass" "grpquota" "true"
> TEST: "-o grpquota" "pass" "grpquota" "true"
> --
> 2.20.0
>
prev parent reply other threads:[~2020-12-07 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 11:41 [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce xiakaixu1987
2020-12-07 17:01 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207170104.GO629293@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox