* Re: [PATCH -next] fs/xfs: convert comma to semicolon
2020-12-11 8:41 [PATCH -next] fs/xfs: convert comma to semicolon Zheng Yongjun
@ 2020-12-11 15:48 ` Brian Foster
2020-12-11 15:51 ` Eric Sandeen
2021-01-20 19:42 ` Darrick J. Wong
2 siblings, 0 replies; 6+ messages in thread
From: Brian Foster @ 2020-12-11 15:48 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: linux-xfs, darrick.wong, linux-kernel
On Fri, Dec 11, 2020 at 04:41:12PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/libxfs/xfs_btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 2d25bab68764..51dbff9b0908 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> * surviving block, and log it.
> */
> xfs_btree_set_numrecs(left, lrecs + rrecs);
> - xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> + xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
>
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] fs/xfs: convert comma to semicolon
2020-12-11 8:41 [PATCH -next] fs/xfs: convert comma to semicolon Zheng Yongjun
2020-12-11 15:48 ` Brian Foster
@ 2020-12-11 15:51 ` Eric Sandeen
2020-12-11 16:17 ` David Laight
2021-01-20 19:42 ` Darrick J. Wong
2 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2020-12-11 15:51 UTC (permalink / raw)
To: Zheng Yongjun, linux-xfs, darrick.wong, linux-kernel
On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
hah, that's an old one. Harmless though, AFAICT.
this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
if we dare add that tag ;)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/libxfs/xfs_btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 2d25bab68764..51dbff9b0908 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> * surviving block, and log it.
> */
> xfs_btree_set_numrecs(left, lrecs + rrecs);
> - xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> + xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH -next] fs/xfs: convert comma to semicolon
2020-12-11 15:51 ` Eric Sandeen
@ 2020-12-11 16:17 ` David Laight
2020-12-11 16:55 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: David Laight @ 2020-12-11 16:17 UTC (permalink / raw)
To: 'Eric Sandeen', Zheng Yongjun, linux-xfs@vger.kernel.org,
darrick.wong@oracle.com, linux-kernel@vger.kernel.org
From: Eric Sandeen
> Sent: 11 December 2020 15:51
>
> On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
>
> hah, that's an old one. Harmless though, AFAICT.
>
> this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> if we dare add that tag ;)
It doesn't 'fix' anything, it is just stylistic.
Completely harmless in every sense.
David
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> > ---
> > fs/xfs/libxfs/xfs_btree.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> > index 2d25bab68764..51dbff9b0908 100644
> > --- a/fs/xfs/libxfs/xfs_btree.c
> > +++ b/fs/xfs/libxfs/xfs_btree.c
> > @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> > * surviving block, and log it.
> > */
> > xfs_btree_set_numrecs(left, lrecs + rrecs);
> > - xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> > + xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> > xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> > xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
> >
> >
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] fs/xfs: convert comma to semicolon
2020-12-11 16:17 ` David Laight
@ 2020-12-11 16:55 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2020-12-11 16:55 UTC (permalink / raw)
To: David Laight, 'Eric Sandeen', Zheng Yongjun,
linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
linux-kernel@vger.kernel.org
On Fri, 2020-12-11 at 16:17 +0000, David Laight wrote:
> From: Eric Sandeen
> > Sent: 11 December 2020 15:51
> >
> > On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > > Replace a comma between expression statements by a semicolon.
> > >
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> >
> > hah, that's an old one. Harmless though, AFAICT.
> >
> > this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> > if we dare add that tag ;)
>
> It doesn't 'fix' anything, it is just stylistic.
> Completely harmless in every sense.
True, so it's not necessary to add a fixes tag here.
The only time a comma->semicolon conversion could 'fix'
something is when it's unintentionally used after something
like an if statement
if (foo)
bar(),
baz();
where now baz() is performed only when the if condition is true
but the indentation indicates that it should always be performed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] fs/xfs: convert comma to semicolon
2020-12-11 8:41 [PATCH -next] fs/xfs: convert comma to semicolon Zheng Yongjun
2020-12-11 15:48 ` Brian Foster
2020-12-11 15:51 ` Eric Sandeen
@ 2021-01-20 19:42 ` Darrick J. Wong
2 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2021-01-20 19:42 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: linux-xfs, darrick.wong, linux-kernel
On Fri, Dec 11, 2020 at 04:41:12PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Apparently I forgot to ack this before merging it...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 2d25bab68764..51dbff9b0908 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> * surviving block, and log it.
> */
> xfs_btree_set_numrecs(left, lrecs + rrecs);
> - xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> + xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
>
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread