* [PATCH] xfsdump: don't try to generate .ltdep in inventory/
@ 2020-10-02 19:35 Eric Sandeen
2020-12-16 22:03 ` Bill O'Donnell
2020-12-16 22:32 ` [PATCH V2] " Eric Sandeen
0 siblings, 2 replies; 5+ messages in thread
From: Eric Sandeen @ 2020-10-02 19:35 UTC (permalink / raw)
To: xfs; +Cc: Thomas Deutschmann
.ltdep gets generated from CFILES, and there are none in inventory/
so trying to generate it in that dir leads to a non-fatal error:
Building inventory
[LTDEP]
gcc: fatal error: no input files
compilation terminated.
inventory/ - like common/ - has files that get linked into other dirs,
and .ltdep is generated there. So, simply remove the .ltdep generation
from the inventory/ dir.
Reported-by: Thomas Deutschmann <whissi@gentoo.org>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/inventory/Makefile b/inventory/Makefile
index cda145e..6624fba 100644
--- a/inventory/Makefile
+++ b/inventory/Makefile
@@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
default install install-dev:
include $(BUILDRULES)
-
--include .ltdep
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xfsdump: don't try to generate .ltdep in inventory/
2020-10-02 19:35 [PATCH] xfsdump: don't try to generate .ltdep in inventory/ Eric Sandeen
@ 2020-12-16 22:03 ` Bill O'Donnell
2020-12-16 22:32 ` [PATCH V2] " Eric Sandeen
1 sibling, 0 replies; 5+ messages in thread
From: Bill O'Donnell @ 2020-12-16 22:03 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs, Thomas Deutschmann
On Fri, Oct 02, 2020 at 02:35:44PM -0500, Eric Sandeen wrote:
> .ltdep gets generated from CFILES, and there are none in inventory/
> so trying to generate it in that dir leads to a non-fatal error:
>
> Building inventory
> [LTDEP]
> gcc: fatal error: no input files
> compilation terminated.
>
> inventory/ - like common/ - has files that get linked into other dirs,
> and .ltdep is generated there. So, simply remove the .ltdep generation
> from the inventory/ dir.
>
> Reported-by: Thomas Deutschmann <whissi@gentoo.org>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/inventory/Makefile b/inventory/Makefile
> index cda145e..6624fba 100644
> --- a/inventory/Makefile
> +++ b/inventory/Makefile
> @@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
> default install install-dev:
>
> include $(BUILDRULES)
> -
> --include .ltdep
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] xfsdump: don't try to generate .ltdep in inventory/
2020-10-02 19:35 [PATCH] xfsdump: don't try to generate .ltdep in inventory/ Eric Sandeen
2020-12-16 22:03 ` Bill O'Donnell
@ 2020-12-16 22:32 ` Eric Sandeen
2020-12-16 23:10 ` Bill O'Donnell
2020-12-17 0:58 ` Darrick J. Wong
1 sibling, 2 replies; 5+ messages in thread
From: Eric Sandeen @ 2020-12-16 22:32 UTC (permalink / raw)
To: xfs; +Cc: Thomas Deutschmann
.ltdep gets generated from CFILES, and there are none in inventory/
so trying to generate it in that dir leads to a non-fatal error when
the include invokes the rule to build the .ltdep file:
Building inventory
[LTDEP]
gcc: fatal error: no input files
compilation terminated.
inventory/ - like common/ - has files that get linked into other dirs,
and .ltdep is generated in those other dirs, not in inventory/.
So, simply remove the .ltdep include/generation from the inventory/
dir, because there is no reason or ability to generate the file here.
Reported-by: Thomas Deutschmann <whissi@gentoo.org>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: more comprehensive problem description
diff --git a/inventory/Makefile b/inventory/Makefile
index cda145e..6624fba 100644
--- a/inventory/Makefile
+++ b/inventory/Makefile
@@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
default install install-dev:
include $(BUILDRULES)
-
--include .ltdep
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] xfsdump: don't try to generate .ltdep in inventory/
2020-12-16 22:32 ` [PATCH V2] " Eric Sandeen
@ 2020-12-16 23:10 ` Bill O'Donnell
2020-12-17 0:58 ` Darrick J. Wong
1 sibling, 0 replies; 5+ messages in thread
From: Bill O'Donnell @ 2020-12-16 23:10 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs, Thomas Deutschmann
On Wed, Dec 16, 2020 at 04:32:07PM -0600, Eric Sandeen wrote:
> .ltdep gets generated from CFILES, and there are none in inventory/
> so trying to generate it in that dir leads to a non-fatal error when
> the include invokes the rule to build the .ltdep file:
>
> Building inventory
> [LTDEP]
> gcc: fatal error: no input files
> compilation terminated.
>
> inventory/ - like common/ - has files that get linked into other dirs,
> and .ltdep is generated in those other dirs, not in inventory/.
>
> So, simply remove the .ltdep include/generation from the inventory/
> dir, because there is no reason or ability to generate the file here.
>
> Reported-by: Thomas Deutschmann <whissi@gentoo.org>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> V2: more comprehensive problem description
>
> diff --git a/inventory/Makefile b/inventory/Makefile
> index cda145e..6624fba 100644
> --- a/inventory/Makefile
> +++ b/inventory/Makefile
> @@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
> default install install-dev:
>
> include $(BUILDRULES)
> -
> --include .ltdep
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] xfsdump: don't try to generate .ltdep in inventory/
2020-12-16 22:32 ` [PATCH V2] " Eric Sandeen
2020-12-16 23:10 ` Bill O'Donnell
@ 2020-12-17 0:58 ` Darrick J. Wong
1 sibling, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2020-12-17 0:58 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs, Thomas Deutschmann
On Wed, Dec 16, 2020 at 04:32:07PM -0600, Eric Sandeen wrote:
> .ltdep gets generated from CFILES, and there are none in inventory/
> so trying to generate it in that dir leads to a non-fatal error when
> the include invokes the rule to build the .ltdep file:
>
> Building inventory
> [LTDEP]
> gcc: fatal error: no input files
> compilation terminated.
>
> inventory/ - like common/ - has files that get linked into other dirs,
> and .ltdep is generated in those other dirs, not in inventory/.
>
> So, simply remove the .ltdep include/generation from the inventory/
> dir, because there is no reason or ability to generate the file here.
>
> Reported-by: Thomas Deutschmann <whissi@gentoo.org>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
/me has long wondered why the source files in inventory and common are
built separately for dump and restore instead of being dumped into a
shared .a file and linked from both tools. There's probably some
reason, though whether or not I really want to go digging into Yet
Another Pile is questionable...
For shutting up the warning,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> V2: more comprehensive problem description
>
> diff --git a/inventory/Makefile b/inventory/Makefile
> index cda145e..6624fba 100644
> --- a/inventory/Makefile
> +++ b/inventory/Makefile
> @@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
> default install install-dev:
>
> include $(BUILDRULES)
> -
> --include .ltdep
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-17 0:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-02 19:35 [PATCH] xfsdump: don't try to generate .ltdep in inventory/ Eric Sandeen
2020-12-16 22:03 ` Bill O'Donnell
2020-12-16 22:32 ` [PATCH V2] " Eric Sandeen
2020-12-16 23:10 ` Bill O'Donnell
2020-12-17 0:58 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox