public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs: make inobtcount visible
Date: Mon, 4 Jan 2021 11:31:42 -0800	[thread overview]
Message-ID: <20210104193142.GN6918@magnolia> (raw)
In-Reply-To: <20210104185754.GI14354@localhost.localdomain>

On Tue, Jan 05, 2021 at 02:57:54AM +0800, Zorro Lang wrote:
> On Mon, Jan 04, 2021 at 10:29:21AM -0600, Eric Sandeen wrote:
> > 
> > 
> > On 1/4/21 9:28 AM, Eric Sandeen wrote:
> > > On 1/4/21 5:30 AM, Zorro Lang wrote:
> > >> When set inobtcount=1/0, we can't see it from xfs geometry report.
> > >> So make it visible.
> > >>
> > >> Signed-off-by: Zorro Lang <zlang@redhat.com>
> > > Hi Zorro - thanks for spotting this.
> > > 
> > > I think the libxfs changes need to hit the kernel first, then we can
> > > pull it in and fix up the report_geom function.  Nothing calls
> > > xfs_fs_geometry directly in userspace, FWIW.
> > 
> > Hah, of course I forgot about libxfs_fs_geometry. o_O
> > 
> > In any case, I think this should hit the kernel first, want to send
> > that patch if it's not already on the list?
> 
> I can give it a try, if Darrick haven't had one in his developing list :)

Why do we need to expose INOBTCNT/inobtcount via the geometry ioctl?
It doesn't expose any user-visible functionality.

--D

> Thanks,
> Zorro
> 
> > 
> > -Eric
> > 
> > > Thanks,
> > > -Eric
> > > 
> > 
> 

  reply	other threads:[~2021-01-04 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 11:30 [PATCH] mkfs: make inobtcount visible Zorro Lang
2021-01-04 15:28 ` Eric Sandeen
2021-01-04 16:29   ` Eric Sandeen
2021-01-04 18:57     ` Zorro Lang
2021-01-04 19:31       ` Darrick J. Wong [this message]
2021-01-05 21:49         ` Eric Sandeen
2021-01-05 21:11 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104193142.GN6918@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox