From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E704FC433E0 for ; Thu, 7 Jan 2021 19:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5C13233CF for ; Thu, 7 Jan 2021 19:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728066AbhAGTlW (ORCPT ); Thu, 7 Jan 2021 14:41:22 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:51054 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729384AbhAGTlW (ORCPT ); Thu, 7 Jan 2021 14:41:22 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107JZvQL156476; Thu, 7 Jan 2021 19:40:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=QenP+tBOGcZZ0lGV/kOtU0cWGKM3YjcSE1dn+bvo7NM=; b=vV40rcNF1utyL8X8mdqhFGwls+EiY4IyBUT+zxQeLqb0fTLr4mwmXO+dxTzfNNLzqt+P yo6E6qmDx8KF3y0FML7Y718HCjjtMgSdZW/qmSoA9d5vu3QZ9OxpzIMtXxIYgu9ZSGYg FQC/FsFwQoDaMDBiLAmOTipORusAjG+Cez9zAwhM6rDFDSPAYNFrl/KD7xoJc38YDYsY 1p+VLLMsc9MMx7rCKUtJCuy1Xsm4et43aZLbjHt+SZjw6bMb7lgE7+9nAAW6Xo91dDqC EAqegNTWfuTpRItsYiGwVM1BK3LounU92zNXeaZCrLDP2YZJf7fPZSCe4gxx45/X1S28 MQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 35wftxdkgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 07 Jan 2021 19:40:39 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107JadDV136271; Thu, 7 Jan 2021 19:38:39 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 35w3qu5q6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Jan 2021 19:38:39 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 107Jcc39025201; Thu, 7 Jan 2021 19:38:38 GMT Received: from localhost (/10.159.138.126) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 07 Jan 2021 11:38:38 -0800 Date: Thu, 7 Jan 2021 11:38:37 -0800 From: "Darrick J. Wong" To: Brian Foster Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 7/9] xfs: remove duplicate wq cancel and log force from attr quiesce Message-ID: <20210107193837.GJ6918@magnolia> References: <20210106174127.805660-1-bfoster@redhat.com> <20210106174127.805660-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106174127.805660-8-bfoster@redhat.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070114 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070114 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jan 06, 2021 at 12:41:25PM -0500, Brian Foster wrote: > These two calls are repeated at the beginning of xfs_log_quiesce(). > Drop them from xfs_quiesce_attr(). > > Signed-off-by: Brian Foster Makes sense, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_super.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 75ada867c665..8fc9044131fc 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -884,11 +884,6 @@ void > xfs_quiesce_attr( > struct xfs_mount *mp) > { > - cancel_delayed_work_sync(&mp->m_log->l_work); > - > - /* force the log to unpin objects from the now complete transactions */ > - xfs_log_force(mp, XFS_LOG_SYNC); > - > xfs_log_clean(mp); > } > > -- > 2.26.2 >