Re: [PATCH v3 2/4] xfs: get rid of xfs_growfs_{data,log}_t

[Gao Xiang <hsiangkao@redhat.com>]

On Mon, Jan 11, 2021 at 08:04:36AM +1100, Dave Chinner wrote:
> On Sat, Jan 09, 2021 at 08:49:34AM +0800, Gao Xiang wrote:
> > On Fri, Jan 08, 2021 at 03:27:21PM -0600, Eric Sandeen wrote:
> > > On 1/8/21 3:21 PM, Darrick J. Wong wrote:
> > > > On Sat, Jan 09, 2021 at 03:09:17AM +0800, Gao Xiang wrote:
> > > >> Such usage isn't encouraged by the kernel coding style.
> > > >>
> > > >> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> > > >> ---
> > > >>  fs/xfs/libxfs/xfs_fs.h |  4 ++--
> > > >>  fs/xfs/xfs_fsops.c     | 12 ++++++------
> > > >>  fs/xfs/xfs_fsops.h     |  4 ++--
> > > >>  fs/xfs/xfs_ioctl.c     |  4 ++--
> > > >>  4 files changed, 12 insertions(+), 12 deletions(-)
> > > >>
> > > >> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> > > >> index 2a2e3cfd94f0..a17313efc1fe 100644
> > > >> --- a/fs/xfs/libxfs/xfs_fs.h
> > > >> +++ b/fs/xfs/libxfs/xfs_fs.h
> > > >> @@ -308,12 +308,12 @@ struct xfs_ag_geometry {
> > > >>  typedef struct xfs_growfs_data {
> > > >>  	__u64		newblocks;	/* new data subvol size, fsblocks */
> > > >>  	__u32		imaxpct;	/* new inode space percentage limit */
> > > >> -} xfs_growfs_data_t;
> > > >> +};
> > > > 
> > > > So long as Eric is ok with fixing this up in xfs_fs_compat.h in
> > > > userspace,
> > > > 
> > > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > > 
> > > Sure, why not :) (tho is growfs really a public interface?  I guess so,
> > > technically, though not documented as such.)
> 
> They are not described in man pages, though they are listed in
> xfsctl(3) so they are definitely public interfaces.
> 
> > Yeah, although I think nobody else uses it (I could leave the typedef
> > definitions only if needed otherwise...)
> 
> It is used elsewhere - ISTR that it is used by a couple of third
> party applications that integrate growing filesystems into their
> other storage management tasks.

Okay, will leave the definitions in the next version.

Thanks,
Gao Xiang

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
>