Re: [PATCH v3 3/4] xfs: hoist out xfs_resizefs_init_new_ags()

[Christoph Hellwig <hch@infradead.org>]

> +	xfs_mount_t		*mp,

Please use the struct type here.

> +	/*
> +	 * Write new AG headers to disk. Non-transactional, but need to be
> +	 * written and completed prior to the growfs transaction being logged.
> +	 * To do this, we use a delayed write buffer list and wait for
> +	 * submission and IO completion of the list as a whole. This allows the
> +	 * IO subsystem to merge all the AG headers in a single AG into a single
> +	 * IO and hide most of the latency of the IO from us.
> +	 *
> +	 * This also means that if we get an error whilst building the buffer
> +	 * list to write, we can cancel the entire list without having written
> +	 * anything.
> +	 */

Maybe move the comment on top of the whole function, as it really
explains what the function does.