Bug#979653: xfsprogs: Incomplete debian/copyright

["Darrick J. Wong" <djwong@kernel.org>]

On Sun, Jan 10, 2021 at 01:23:58AM +0100, Bastian Germann wrote:
> Am 09.01.21 um 23:53 schrieb Eric Sandeen:
> > On 1/9/21 2:42 PM, Bastian Germann wrote:
> > > On Sat, 9 Jan 2021 19:31:50 +0100 Bastian Germann <bastiangermann@fishpost.de> wrote:
> > > > xfsprogs' debian/copyright only mentions Silicon Graphics, Inc.'s copyright. There are other copyright holders, e.g. Oracle, Red Hat, Google LLC, and several individuals. Please provide a complete copyright file and convert it to the machine-readable format.
> > > 
> > > Please find a copyright file enclosed.
> > 
> > Hi Bastian -
> > 
> > I'll take an update to this file, but what are the /minimum/ requirements
> > per Debian policy?
> 
> https://www.debian.org/doc/debian-policy/ch-archive.html#copyright-considerations
> 
> The minimum requirements are that you include the license info.
> The copyright info also has to be included in some cases, essentially for
> each file that is included in compiled form in a binary package you have to
> reproduce its copyright info if the license requires the copyright to be
> retained in binary distributions.
> 
> > 
> > Tracking everything by file+name(s)+year seems rather pointless - it's all
> > present in the accompanying source, and keeping it up to date at this
> > granularity seems like make-work doomed to be perpetually out of sync.
> 
> You can get rid of all the file names. The license info has to be included
> (GPL-2, LGPL-2.1, GPL-3+ with autoconf exception). One can argue that the
> FSF unlimited permission license text (m4/*) also has to be included by
> Policy.
> 
> The (L)GPL requires the copyright statements to be included.
> 
> I have reduced the given copyright file to a more maintainable version. It
> still keeps some file names (not required) so that one can identify the
> primary copyright holders and the LGPL parts easily.
> 
> > I'd prefer to populate it with the minimum required information in
> > order to minimize churn and maximize ongoing correctness if possible.
> > 
> > Thanks,
> > -Eric
> > 

> Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> Upstream-Name: xfsprogs
> Comment: This package was debianized by Nathan Scott <nathans@debian.org>
> Source: https://www.kernel.org/pub/linux/utils/fs/xfs/xfsprogs/
> 
> Files: *
> Copyright:
>  1995-2013 Silicon Graphics, Inc.
>  2010-2018 Red Hat, Inc.
>  2016-2020 Oracle.  All Rights Reserved.

/me notes that a lot of the Oracle-copyright files are actually GPL-2+,
not GPL-2.  That might not be obvious because I bungled some of the SPDX
tags when spdx deprecated the "GPL-2.0+" tag and we had to replace them
all with "GPL-2.0-or-later", though it looks like they've all been
cleaned up at this point.

Question: How can we autogenerate debian/copyright from the source files
in the git repo?  In the long run I think it best that this becomes
something we can automate when tagging a new upstream release.

--D

> Comment: For most files, only one of the copyrights applies.
> License: GPL-2
> 
> Files:
>  libhandle/*.c
> Copyright: 1995, 2001-2002, 2005 Silicon Graphics, Inc.
> Comment: This also applies to some header files.
> License: LGPL-2.1
>  This library is free software; you can redistribute it and/or modify it
>  under the terms of the GNU Lesser General Public License as published by
>  the Free Software Foundation; version 2.1 of the License.
>  .
>  This library is distributed in the hope that it will be useful, but WITHOUT
>  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>  FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
>  for more details.
>  .
>  On Debian systems, refer to /usr/share/common-licenses/LGPL-2.1
>  for the complete text of the GNU Lesser General Public License.
> 
> Files: config.*
> Copyright: 1992-2013 Free Software Foundation, Inc.
> License: GPL-3+ with autoconf exception
>  This file is free software; you can redistribute it and/or modify it
>  under the terms of the GNU General Public License as published by
>  the Free Software Foundation; either version 3 of the License, or
>  (at your option) any later version.
>  .
>  This program is distributed in the hope that it will be useful, but
>  WITHOUT ANY WARRANTY; without even the implied warranty of
>  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>  General Public License for more details.
>  .
>  You should have received a copy of the GNU General Public License
>  along with this program; if not, see <http://www.gnu.org/licenses/>.
>  .
>  As a special exception to the GNU General Public License, if you
>  distribute this file as part of a program that contains a
>  configuration script generated by Autoconf, you may include it under
>  the same distribution terms that you use for the rest of that
>  program.  This Exception is an additional permission under section 7
>  of the GNU General Public License, version 3 ("GPLv3").
>  .
>  On Debian systems, the full text of the GNU General Public License version 3
>  License can be found in /usr/share/common-licenses/GPL-3 file.
> 
> Files: io/copy_file_range.c
> Copyright: 2016 Netapp, Inc. All rights reserved.
> License: GPL-2
> 
> Files: io/encrypt.c
> Copyright: 2016, 2019 Google LLC
> License: GPL-2
> 
> Files:
>  io/link.c
>  libxfs/xfs_iext_tree.c
> Copyright: 2014, 2017 Christoph Hellwig.
> License: GPL-2
> 
> Files: io/log_writes.c
> Copyright: 2017 Intel Corporation.
> License: GPL-2
> 
> Files: io/utimes.c
> Copyright: 2016 Deepa Dinamani
> License: GPL-2
> 
> Files: libfrog/radix-tree.*
> Copyright:
>  2001 Momchil Velikov
>  2001 Christoph Hellwig
>  2005 SGI, Christoph Lameter <clameter@sgi.com>
> License: GPL-2
> 
> Files: libxfs/xfs_log_rlimit.c
> Copyright: 2013 Jie Liu.
> License: GPL-2
> 
> License: GPL-2
>  This program is free software; you can redistribute it and/or modify it under
>  the terms of the GNU General Public License as published by the Free Software
>  Foundation; version 2 of the License.
>  .
>  This program is distributed in the hope that it will be useful, but WITHOUT
>  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
>  FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>  .
>  You should have received a copy of the GNU General Public License along with
>  this package; if not, write to the Free Software Foundation, Inc., 51 Franklin
>  St, Fifth Floor, Boston, MA  02110-1301 USA
>  .
>  On Debian systems, the full text of the GNU General Public License version 2
>  License can be found in /usr/share/common-licenses/GPL-2 file.