From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDE0C433E0 for ; Tue, 12 Jan 2021 22:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AABC6230F9 for ; Tue, 12 Jan 2021 22:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436713AbhALWpi (ORCPT ); Tue, 12 Jan 2021 17:45:38 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:36737 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730139AbhALWpi (ORCPT ); Tue, 12 Jan 2021 17:45:38 -0500 Received: from dread.disaster.area (pa49-179-167-107.pa.nsw.optusnet.com.au [49.179.167.107]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id DA55B3E2FF5; Wed, 13 Jan 2021 09:44:55 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kzSPH-005ptb-3z; Wed, 13 Jan 2021 09:44:55 +1100 Date: Wed, 13 Jan 2021 09:44:55 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, avi@scylladb.com Subject: Re: [PATCH 04/10] xfs: remove the buffered I/O fallback assert Message-ID: <20210112224455.GZ331610@dread.disaster.area> References: <20210112162616.2003366-1-hch@lst.de> <20210112162616.2003366-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112162616.2003366-5-hch@lst.de> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Ubgvt5aN c=1 sm=1 tr=0 cx=a_idp_d a=+wqVUQIkAh0lLYI+QRsciw==:117 a=+wqVUQIkAh0lLYI+QRsciw==:17 a=kj9zAlcOel0A:10 a=EmqxpYm9HcoA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=qlM9xY6_Wff9mqQ8tTEA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jan 12, 2021 at 05:26:10PM +0100, Christoph Hellwig wrote: > The iomap code has been designed from the start not to do magic fallback, > so remove the assert in preparation for further code cleanups. > > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_file.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index ae7313ccaa11ed..97836ec53397d4 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -610,12 +610,6 @@ xfs_file_dio_write( > out: > if (iolock) > xfs_iunlock(ip, iolock); > - > - /* > - * No fallback to buffered IO after short writes for XFS, direct I/O > - * will either complete fully or return an error. > - */ > - ASSERT(ret < 0 || ret == count); > return ret; > } Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com