From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: test mkfs.xfs config files
Date: Sun, 17 Jan 2021 20:27:04 -0800 [thread overview]
Message-ID: <20210118042704.GG3134581@magnolia> (raw)
In-Reply-To: <20210117231848.GB78965@dread.disaster.area>
On Mon, Jan 18, 2021 at 10:18:48AM +1100, Dave Chinner wrote:
> On Fri, Jan 15, 2021 at 05:46:07PM -0800, Darrick J. Wong wrote:
> > On Thu, Oct 29, 2020 at 02:27:13PM -0700, Darrick J. Wong wrote:
> > > On Wed, Oct 28, 2020 at 07:54:50AM +1100, Dave Chinner wrote:
> > > > +echo End of line comment
> > > > +test_mkfs_config << ENDL
> > > > +[metadata]
> > > > +crc = 0 ; This is an eol comment.
> > >
> > > Hey, wait a minute, the manpage didn't say I could use semicolon
> > > comments! :)
> > >
> > > The libinih page https://github.com/benhoyt/inih says you can though.
> > >
> > > Would you mind making a note of that in patch 5 above, please?
> >
> > Ping? The mkfs code has been merged upstream; we ought to land the
> > functionality tests.
>
> Nothing in this patch needs to change, AFAIA, because you were
> referring to the xfsprogs mkfs patchset in your comment. So this
> is really only waiting on review, right? Do I need to repost it?
Probably, as it's entirely possible that it's gotten lost in Eryu's mail
stream.
--D
> -Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-01-18 4:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 20:54 [PATCH] xfs: test mkfs.xfs config files Dave Chinner
2020-10-29 21:27 ` Darrick J. Wong
2021-01-16 1:46 ` Darrick J. Wong
2021-01-17 23:18 ` Dave Chinner
2021-01-18 4:27 ` Darrick J. Wong [this message]
2021-01-24 13:33 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118042704.GG3134581@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox