public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: set inode size after creating symlink
Date: Thu, 21 Jan 2021 13:21:33 -0600	[thread overview]
Message-ID: <20210121192133.GA9807@jeffrey-work-20.04> (raw)
In-Reply-To: <20210121184137.GB1282159@magnolia>

On Thu, Jan 21, 2021 at 10:41:37AM -0800, Darrick J. Wong wrote:
> Do directories have the same problem?

Yes, I just checked in a VM. While ecryptfs does call vfs_getattr(), it
only uses the "blocks" value to supplement the data from an identical
generic_fillattr() call to what ecryptfs_getattr_link() uses. The reported
size still comes from i_size_read().

V/R,
Jeffrey Mitchell

  reply	other threads:[~2021-01-21 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 15:19 [PATCH] xfs: set inode size after creating symlink Jeffrey Mitchell
2021-01-21 18:41 ` Darrick J. Wong
2021-01-21 19:21   ` Jeffrey Mitchell [this message]
2021-01-21 19:58 ` Brian Foster
2021-01-22  8:02 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121192133.GA9807@jeffrey-work-20.04 \
    --to=jeffrey.mitchell@starlab.io \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox