From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org, david@fromorbit.com
Subject: Re: [PATCH 3/3] xfs: set WQ_SYSFS on all workqueues
Date: Sun, 24 Jan 2021 09:54:54 +0000 [thread overview]
Message-ID: <20210124095454.GG670331@infradead.org> (raw)
In-Reply-To: <161142799960.2173328.12558377173737512680.stgit@magnolia>
> log->l_ioend_workqueue = alloc_workqueue("xfs-log/%s",
> - WQ_MEM_RECLAIM | WQ_FREEZABLE | WQ_HIGHPRI, 0,
> - mp->m_super->s_id);
> + WQ_SYSFS | WQ_MEM_RECLAIM | WQ_FREEZABLE | WQ_HIGHPRI,
> + 0, mp->m_super->s_id);
This is just used for log I/O completions which are effectlively single
thread. I don't see any reason to adjust the parameters here.
> if (!log->l_ioend_workqueue)
> goto out_free_iclog;
>
> diff --git a/fs/xfs/xfs_mru_cache.c b/fs/xfs/xfs_mru_cache.c
> index a06661dac5be..b6dab34e361d 100644
> --- a/fs/xfs/xfs_mru_cache.c
> +++ b/fs/xfs/xfs_mru_cache.c
> @@ -294,7 +294,7 @@ int
> xfs_mru_cache_init(void)
> {
> xfs_mru_reap_wq = alloc_workqueue("xfs_mru_cache",
> - WQ_MEM_RECLAIM|WQ_FREEZABLE, 1);
> + WQ_SYSFS | WQ_MEM_RECLAIM | WQ_FREEZABLE, 1);
> if (!xfs_mru_reap_wq)
> return -ENOMEM;
This one also hasn't ever been something we tune, so I don't think there
is a good case for enabling WQ_SYSFS.
I've stopped here. I think we should have a good use case for making
workqueues show up in sysfs based on that we:
a) have resons to adjust them ever
b) actually having them easily discoverable and documented for adminds
to tune
next prev parent reply other threads:[~2021-01-24 9:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:53 [PATCHSET 0/3] xfs: speed up parallel workqueues Darrick J. Wong
2021-01-23 18:53 ` [PATCH 1/3] xfs: increase the default parallelism levels of pwork clients Darrick J. Wong
2021-01-24 9:57 ` Christoph Hellwig
2021-01-25 23:07 ` Darrick J. Wong
2021-01-26 5:04 ` [PATCH v2.1 " Darrick J. Wong
2021-01-26 20:46 ` Dave Chinner
2021-01-26 23:32 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 2/3] xfs: use unbounded workqueues for parallel work Darrick J. Wong
2021-01-24 9:51 ` Christoph Hellwig
2021-01-25 23:18 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 3/3] xfs: set WQ_SYSFS on all workqueues Darrick J. Wong
2021-01-24 9:54 ` Christoph Hellwig [this message]
2021-01-25 23:30 ` Darrick J. Wong
2021-01-26 5:06 ` [PATCH 4/3] xfs: set WQ_SYSFS on all workqueues in debug mode Darrick J. Wong
2021-01-26 20:48 ` Dave Chinner
2021-01-27 17:03 ` Christoph Hellwig
2021-01-27 23:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124095454.GG670331@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox