From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org, david@fromorbit.com
Subject: Re: [PATCH 4/3] xfs: set WQ_SYSFS on all workqueues in debug mode
Date: Wed, 27 Jan 2021 17:03:06 +0000 [thread overview]
Message-ID: <20210127170306.GC1730140@infradead.org> (raw)
In-Reply-To: <20210126050619.GT7698@magnolia>
On Mon, Jan 25, 2021 at 09:06:19PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> When CONFIG_XFS_DEBUG=y, set WQ_SYSFS on all workqueues that we create
> so that we (developers) have a means to monitor cpu affinity and whatnot
> for background workers. In the next patchset we'll expose knobs for
> some of the workqueues publicly and document it, but not now.
I don't really think this is a very good idea. If we want something like
this it should be kernel-wide and coordinated with the workqueue
maintainer, but I'm a little doubtful about the use case.
next prev parent reply other threads:[~2021-01-27 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:53 [PATCHSET 0/3] xfs: speed up parallel workqueues Darrick J. Wong
2021-01-23 18:53 ` [PATCH 1/3] xfs: increase the default parallelism levels of pwork clients Darrick J. Wong
2021-01-24 9:57 ` Christoph Hellwig
2021-01-25 23:07 ` Darrick J. Wong
2021-01-26 5:04 ` [PATCH v2.1 " Darrick J. Wong
2021-01-26 20:46 ` Dave Chinner
2021-01-26 23:32 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 2/3] xfs: use unbounded workqueues for parallel work Darrick J. Wong
2021-01-24 9:51 ` Christoph Hellwig
2021-01-25 23:18 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 3/3] xfs: set WQ_SYSFS on all workqueues Darrick J. Wong
2021-01-24 9:54 ` Christoph Hellwig
2021-01-25 23:30 ` Darrick J. Wong
2021-01-26 5:06 ` [PATCH 4/3] xfs: set WQ_SYSFS on all workqueues in debug mode Darrick J. Wong
2021-01-26 20:48 ` Dave Chinner
2021-01-27 17:03 ` Christoph Hellwig [this message]
2021-01-27 23:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127170306.GC1730140@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox