From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44811C433DB for ; Thu, 28 Jan 2021 08:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0784664DDA for ; Thu, 28 Jan 2021 08:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232409AbhA1IDM (ORCPT ); Thu, 28 Jan 2021 03:03:12 -0500 Received: from verein.lst.de ([213.95.11.211]:56327 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232218AbhA1IB1 (ORCPT ); Thu, 28 Jan 2021 03:01:27 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id A26EB68AFE; Thu, 28 Jan 2021 09:00:34 +0100 (CET) Date: Thu, 28 Jan 2021 09:00:34 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync Message-ID: <20210128080034.GA29023@lst.de> References: <20210122164643.620257-1-hch@lst.de> <20210122164643.620257-3-hch@lst.de> <20210125131618.GA2047559@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210125131618.GA2047559@bfoster> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jan 25, 2021 at 08:16:18AM -0500, Brian Foster wrote: > > - error = xfs_fsync_flush_log(ip, datasync, &log_flushed); > > + /* > > + * Any inode that has dirty modifications in the log is pinned. The > > + * racy check here for a pinned inode while not catch modifications > > s/while/will/ ? Yes. Darrick, can you fix this up when applying the patch, or do you want me to resend?