From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org,
david@fromorbit.com, bfoster@redhat.com
Subject: Re: [PATCH 11/11] xfs: don't bounce the iolock between free_{eof,cow}blocks
Date: Thu, 28 Jan 2021 09:30:02 +0000 [thread overview]
Message-ID: <20210128093002.GE1967319@infradead.org> (raw)
In-Reply-To: <161181388185.1525433.9983196119474305213.stgit@magnolia>
On Wed, Jan 27, 2021 at 10:04:41PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Since xfs_inode_free_eofblocks and xfs_inode_free_cowblocks are now
> internal static functions, we can save ourselves a cycling of the iolock
> by passing the lock state out to xfs_blockgc_scan_inode and letting it
> do all the unlocking.
Looks good, although normally we use lock_flags and not unlockflags
for this kind of variable, and maybe we should stick to that here.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-01-28 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 6:03 [PATCHSET v5 00/11] xfs: consolidate posteof and cowblocks cleanup Darrick J. Wong
2021-01-28 6:03 ` [PATCH 01/11] xfs: relocate the eofb/cowb workqueue functions Darrick J. Wong
2021-01-28 6:03 ` [PATCH 02/11] xfs: hide xfs_icache_free_eofblocks Darrick J. Wong
2021-01-28 6:03 ` [PATCH 03/11] xfs: hide xfs_icache_free_cowblocks Darrick J. Wong
2021-01-28 6:04 ` [PATCH 04/11] xfs: remove trivial eof/cowblocks functions Darrick J. Wong
2021-01-28 6:04 ` [PATCH 05/11] xfs: consolidate incore inode radix tree posteof/cowblocks tags Darrick J. Wong
2021-01-28 6:04 ` [PATCH 06/11] xfs: consolidate the eofblocks and cowblocks workers Darrick J. Wong
2021-01-28 6:04 ` [PATCH 07/11] xfs: only walk the incore inode tree once per blockgc scan Darrick J. Wong
2021-01-28 6:04 ` [PATCH 08/11] xfs: rename block gc start and stop functions Darrick J. Wong
2021-01-28 6:04 ` [PATCH 09/11] xfs: parallelize block preallocation garbage collection Darrick J. Wong
2021-01-28 6:04 ` [PATCH 10/11] xfs: expose the blockgc workqueue knobs publicly Darrick J. Wong
2021-01-28 6:04 ` [PATCH 11/11] xfs: don't bounce the iolock between free_{eof,cow}blocks Darrick J. Wong
2021-01-28 9:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128093002.GE1967319@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox