Re: [PATCH 05/13] xfs: fix up build warnings when quotas are disabled

Christoph Hellwig
2021-01-28T18:27:36Z

On Thu, Jan 28, 2021 at 10:22:49AM -0800, Darrick J. Wong wrote:
> > > -#define xfs_qm_dqrele(d)
> > > -#define xfs_qm_statvfs(ip, s)
> > > +#define xfs_qm_dqrele(d) do { (d) = (d); } while(0)
> >
> > What's the need for the assignment, out of curiosity?
>
> It shuts up a gcc warning about how the dquot pointer is set but never
> used. One hopes the same gcc is smart enough not to generate any code
> for this.

The alternative would be to turn these stubs into inline functions,
which would also kill the warning.