* [PATCH] xfs: fix unused variable build warning in xfs_log.c
@ 2021-02-05 3:18 John Hubbard
2021-02-05 3:30 ` Darrick J. Wong
2021-02-05 3:58 ` Chaitanya Kulkarni
0 siblings, 2 replies; 4+ messages in thread
From: John Hubbard @ 2021-02-05 3:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-xfs, Linux Next, LKML, John Hubbard, Brian Foster,
Christoph Hellwig, Darrick J . Wong, Allison Henderson
Delete the unused "log" variable in xfs_log_cover().
Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
Hi,
I just ran into this on today's linux-next, so here you go!
thanks,
John Hubbard
NVIDIA
fs/xfs/xfs_log.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 58699881c100..5a9cca3f7cbf 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1108,7 +1108,6 @@ static int
xfs_log_cover(
struct xfs_mount *mp)
{
- struct xlog *log = mp->m_log;
int error = 0;
bool need_covered;
base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c
2021-02-05 3:18 [PATCH] xfs: fix unused variable build warning in xfs_log.c John Hubbard
@ 2021-02-05 3:30 ` Darrick J. Wong
2021-02-05 3:49 ` John Hubbard
2021-02-05 3:58 ` Chaitanya Kulkarni
1 sibling, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2021-02-05 3:30 UTC (permalink / raw)
To: John Hubbard
Cc: Stephen Rothwell, linux-xfs, Linux Next, LKML, Brian Foster,
Christoph Hellwig, Allison Henderson
On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
> Delete the unused "log" variable in xfs_log_cover().
>
> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
> Cc: Brian Foster <bfoster@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Allison Henderson <allison.henderson@oracle.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> Hi,
>
> I just ran into this on today's linux-next, so here you go!
Thanks for the tipoff, I just realized with horror that I got the git
push wrong and never actually updated xfs-linux.git#for-next. This (and
all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
for-next.
Sigh..... so much for trying to get things in for testing. :(
--D
>
> thanks,
> John Hubbard
> NVIDIA
>
> fs/xfs/xfs_log.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 58699881c100..5a9cca3f7cbf 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1108,7 +1108,6 @@ static int
> xfs_log_cover(
> struct xfs_mount *mp)
> {
> - struct xlog *log = mp->m_log;
> int error = 0;
> bool need_covered;
>
>
> base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c
2021-02-05 3:30 ` Darrick J. Wong
@ 2021-02-05 3:49 ` John Hubbard
0 siblings, 0 replies; 4+ messages in thread
From: John Hubbard @ 2021-02-05 3:49 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Stephen Rothwell, linux-xfs, Linux Next, LKML, Brian Foster,
Christoph Hellwig, Allison Henderson
On 2/4/21 7:30 PM, Darrick J. Wong wrote:
> On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
>> Delete the unused "log" variable in xfs_log_cover().
>>
>> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
>> Cc: Brian Foster <bfoster@redhat.com>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Darrick J. Wong <djwong@kernel.org>
>> Cc: Allison Henderson <allison.henderson@oracle.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>> Hi,
>>
>> I just ran into this on today's linux-next, so here you go!
>
> Thanks for the tipoff, I just realized with horror that I got the git
> push wrong and never actually updated xfs-linux.git#for-next. This (and
> all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
> for-next.
>
> Sigh..... so much for trying to get things in for testing. :(
>
Well, if it's any consolation, this is the *only* warning that fired during
my particular build, in linux-next. :)
thanks,
--
John Hubbard
NVIDIA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c
2021-02-05 3:18 [PATCH] xfs: fix unused variable build warning in xfs_log.c John Hubbard
2021-02-05 3:30 ` Darrick J. Wong
@ 2021-02-05 3:58 ` Chaitanya Kulkarni
1 sibling, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-05 3:58 UTC (permalink / raw)
To: John Hubbard, Stephen Rothwell
Cc: linux-xfs@vger.kernel.org, Linux Next, LKML, Brian Foster,
Christoph Hellwig, Darrick J . Wong, Allison Henderson
On 2/4/21 19:20, John Hubbard wrote:
> Delete the unused "log" variable in xfs_log_cover().
>
> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
> Cc: Brian Foster <bfoster@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Allison Henderson <allison.henderson@oracle.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-05 4:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-05 3:18 [PATCH] xfs: fix unused variable build warning in xfs_log.c John Hubbard
2021-02-05 3:30 ` Darrick J. Wong
2021-02-05 3:49 ` John Hubbard
2021-02-05 3:58 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox