Re: [PATCH 3/4] debian: Regenerate config.guess using debhelper

Dave Chinner
2021-02-21T22:06:24Z

On Sat, Feb 20, 2021 at 11:16:57PM -0800, Steve Langasek wrote:
>
>
> On February 20, 2021 8:11:39 PM PST, Dave Chinner <david@fromorbit.com> wrote:
> >On Sat, Feb 20, 2021 at 01:16:08PM +0100, Bastian Germann wrote:
> >> This is a change introduced in 5.10.0-2ubuntu2 with the changelog:
> >>
> >> > xfsprogs upstream has regressed config.guess, so use
> >> > dh_update_autotools_config.
> >
> >What regression?
> >
> >The xfsprogs build generates config.guess with the libtool
> >infrastructure installed on the build machine. So I'm not sure
> >how/what we've regressed here, because AFAIK we haven't changed
> >anything here recently...
>
> This upstream release ended up with an older version of config.guess in the tarball. Specifically, it was too old to recognize RISC-V as an architecture.

So was the RISC-V architecture added to the ubuntu build between the
uploads of the previous version of xfsprogs and xfsprogs-5.10.0? Or
is this an actual regression where the maintainer signed tarball had
RISC-V support in it and now it doesn't?

FWIW, where are you getting the tarballs from? Are you downloading
the maintainer signed tarballs from here:

https://mirrors.edge.kernel.org/pub/linux/utils/fs/xfs/xfsprogs/

Or pulling the git.kernel.org built tarball that is autogenerated
from the release tag?

> >> @echo "== dpkg-buildpackage: configure" 1>&2
> >> $(checkdir)
> >> AUTOHEADER=/bin/true dh_autoreconf
> >> + dh_update_autotools_config
> >> $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h
> >
> >Why would running at tool that does a search-n-replace of built
> >config.guess files do anything when run before the build runs
> >libtoolize to copy in the config.guess file it uses? I'm a bit
> >confused by this...
>
> Autoreconf was not copying in a newer version of config.guess from the system, because of the specific subset of autotools used by this project.

That sounds wrong. AIUI, autoreconf doesn't copy in anything.

$ man 7 dh-autoreconf
....
CAVEATS
dh_autoreconf is mostly a superset of the
dh_update_autotools_config debhelper command included in
debhelper since version 9.20160115. When using the dh
sequencer, dh_update_autotools_config is run before
dh_autoreconf and updates the config.guess and config.sub
files. This is required in cases where autoreconf does not
update config.guess and config.sub itself.

So isn't the dh_update_autotools_config call in the wrong place
here?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com