Re: [PATCH 1/4] debian: Drop trying to create upstream distribution

Darrick J. Wong
2021-02-23T03:07:54Z

On Sun, Feb 21, 2021 at 03:01:29PM +1100, Dave Chinner wrote:
> On Sat, Feb 20, 2021 at 01:16:06PM +0100, Bastian Germann wrote:
> > This is a change introduced in 4.3.0+nmu1ubuntu1.
>
> Why? When the change was made is not important, explaining why the
> change needs to be made is what should be in the commit message.
> i.e. Tell us why this isn't needed any more...

Yes, this is vital information to have in the commit message.

I'm guessing it has something to do with the fact that 'make dist' tries
to create source tarballs, which is a strange thing to do during the
binary build, and in any case it ultimately fails because tarball
generation now requires .gitcensus, which is cleaned out and then
requires git to regeneration, which you can't do when you're building
from a source tarball?

<shrug> Hm?

--D

> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com