Re: [PATCH 3/4] debian: Regenerate config.guess using debhelper

Eric Sandeen
2021-02-22T19:26:44Z

On 2/21/21 8:44 PM, Dave Chinner wrote:
> On Sun, Feb 21, 2021 at 04:16:39PM -0800, Steve Langasek wrote:
>> On Mon, Feb 22, 2021 at 09:04:43AM +1100, Dave Chinner wrote:
>>
>>>> This upstream release ended up with an older version of config.guess in
>>>> the tarball. Specifically, it was too old to recognize RISC-V as an
>>>> architecture.
>>
>>> So was the RISC-V architecture added to the ubuntu build between the
>>> uploads of the previous version of xfsprogs and xfsprogs-5.10.0? Or
>>> is this an actual regression where the maintainer signed tarball had
>>> RISC-V support in it and now it doesn't?
>>
>> This is a regression. The previous tarball (5.6.0) had a newer config.guess
>> that recognized RISC-V, the newer one (5.10.0) had an older config.guess.
>
> Ok.
>
> Eric, did you change the machine you did the release build from?

I don't recall doing so, but I must have. I guess I remember this coming up
a while ago and maybe I failed to change process in a sticky way. :/

But - if my local toolchain can cause a regression in a major distro, it seems
like this patch to regenerate is the obvious path forward, to control
the distro-specific build, and not be subject to my personal toolchain whims.

Is that not best practice? (I honestly don't know.)

-Eric