Re: [PATCH 3/4] debian: Regenerate config.guess using debhelper

Dave Chinner
2021-02-22T02:45:15Z

On Sun, Feb 21, 2021 at 04:16:39PM -0800, Steve Langasek wrote:
> On Mon, Feb 22, 2021 at 09:04:43AM +1100, Dave Chinner wrote:
>
> > > This upstream release ended up with an older version of config.guess in
> > > the tarball. Specifically, it was too old to recognize RISC-V as an
> > > architecture.
>
> > So was the RISC-V architecture added to the ubuntu build between the
> > uploads of the previous version of xfsprogs and xfsprogs-5.10.0? Or
> > is this an actual regression where the maintainer signed tarball had
> > RISC-V support in it and now it doesn't?
>
> This is a regression. The previous tarball (5.6.0) had a newer config.guess
> that recognized RISC-V, the newer one (5.10.0) had an older config.guess.

Ok.

Eric, did you change the machine you did the release build from?

> > $ man 7 dh-autoreconf
> > ....
> > CAVEATS
> > dh_autoreconf is mostly a superset of the
> > dh_update_autotools_config debhelper command included in
> > debhelper since version 9.20160115. When using the dh
> > sequencer, dh_update_autotools_config is run before
> > dh_autoreconf and updates the config.guess and config.sub
> > files. This is required in cases where autoreconf does not
> > update config.guess and config.sub itself.
>
> > So isn't the dh_update_autotools_config call in the wrong place
> > here?
>
> Documentation notwithstanding, dh_autoreconf was definitively NOT copying in
> the newer config.guess, and we have the build logs to prove it.
>
> https://launchpad.net/ubuntu/+source/xfsprogs/5.10.0-2ubuntu1/+build/20952006

I'm not denying that it fixed your problem. As a reviewer, I'm
supposed to point out where the proposed fix doesn't match with
expected usage. And as a reviewer, I expect that patched get changed
to address problems that are found before they are committed, not to
be told:

> I don't know in what sense this would be the "wrong" place to call it,
> because it fixes the build failure, which is what I care about.

"It made my problem go away, so my job is done."

You didn't report it upstream so we could avoid the regression in
future, to either the debian package maintainers or the XFS lists.
Nor do you seem to care if the fix is correct or whether anyone else
might need it.

In future, if there is a regression in the upstream xfsprogs
package, please report it upstream and not just keep it to yourself
and hack around it.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com