From: Dave Chinner <david@fromorbit.com>
To: Bastian Germann <bastiangermann@fishpost.de>
Cc: linux-xfs@vger.kernel.org, Steve Langasek <steve.langasek@ubuntu.com>
Subject: Re: [PATCH 3/4] debian: Regenerate config.guess using debhelper
Date: Sun, 21 Feb 2021 15:11:39 +1100 [thread overview]
Message-ID: <20210221041139.GL4662@dread.disaster.area> (raw)
In-Reply-To: <20210220121610.3982-4-bastiangermann@fishpost.de>
On Sat, Feb 20, 2021 at 01:16:08PM +0100, Bastian Germann wrote:
> This is a change introduced in 5.10.0-2ubuntu2 with the changelog:
>
> > xfsprogs upstream has regressed config.guess, so use
> > dh_update_autotools_config.
What regression?
The xfsprogs build generates config.guess with the libtool
infrastructure installed on the build machine. So I'm not sure
how/what we've regressed here, because AFAIK we haven't changed
anything here recently...
> Reported-by: Steve Langasek <steve.langasek@ubuntu.com>
> Signed-off-by: Bastian Germann <bastiangermann@fishpost.de>
> ---
> debian/changelog | 3 +++
> debian/rules | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/debian/changelog b/debian/changelog
> index c77f04ab..6cc9926b 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -4,6 +4,9 @@ xfsprogs (5.11.0-rc0-1) experimental; urgency=medium
> * Drop trying to create upstream distribution
> * Enable CET on amd64
>
> + [ Steve Langasek ]
> + * Regenerate config.guess using debhelper
> +
> -- Bastian Germann <bastiangermann@fishpost.de> Sat, 20 Feb 2021 11:57:31 +0100
>
> xfsprogs (5.10.0-3) unstable; urgency=medium
> diff --git a/debian/rules b/debian/rules
> index dd093f2c..1913ccb6 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -49,6 +49,7 @@ config: .census
> @echo "== dpkg-buildpackage: configure" 1>&2
> $(checkdir)
> AUTOHEADER=/bin/true dh_autoreconf
> + dh_update_autotools_config
> $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h
Why would running at tool that does a search-n-replace of built
config.guess files do anything when run before the build runs
libtoolize to copy in the config.guess file it uses? I'm a bit
confused by this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-02-21 4:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 12:16 [PATCH 0/4] debian: Integrate Debian/Ubuntu changes Bastian Germann
2021-02-20 12:16 ` [PATCH 1/4] debian: Drop trying to create upstream distribution Bastian Germann
2021-02-21 4:01 ` Dave Chinner
2021-02-23 3:07 ` Darrick J. Wong
2021-02-20 12:16 ` [PATCH 2/4] debian: Enable CET on amd64 Bastian Germann
2021-02-21 3:59 ` Dave Chinner
2021-02-21 4:02 ` NACK " Dimitri John Ledkov
2021-02-21 4:28 ` Dave Chinner
2021-02-21 4:32 ` Dimitri John Ledkov
2021-02-21 21:37 ` Dave Chinner
2021-02-20 12:16 ` [PATCH 3/4] debian: Regenerate config.guess using debhelper Bastian Germann
2021-02-21 4:11 ` Dave Chinner [this message]
2021-02-21 7:16 ` Steve Langasek
2021-02-21 22:04 ` Dave Chinner
2021-02-22 0:16 ` Steve Langasek
2021-02-22 2:44 ` Dave Chinner
2021-02-22 19:23 ` Eric Sandeen
2021-02-23 20:51 ` Dave Chinner
2021-02-20 12:16 ` [PATCH 4/4] debian: Build-depend on libinih-dev with udeb package Bastian Germann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221041139.GL4662@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bastiangermann@fishpost.de \
--cc=linux-xfs@vger.kernel.org \
--cc=steve.langasek@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox