From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03264C433DB for ; Sun, 21 Feb 2021 22:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C435D64E57 for ; Sun, 21 Feb 2021 22:06:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbhBUWF7 (ORCPT ); Sun, 21 Feb 2021 17:05:59 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:48152 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhBUWF2 (ORCPT ); Sun, 21 Feb 2021 17:05:28 -0500 Received: from dread.disaster.area (pa49-179-130-210.pa.nsw.optusnet.com.au [49.179.130.210]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 6F2911040F99; Mon, 22 Feb 2021 09:04:44 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1lDwqJ-00FiwL-0b; Mon, 22 Feb 2021 09:04:43 +1100 Date: Mon, 22 Feb 2021 09:04:43 +1100 From: Dave Chinner To: Steve Langasek Cc: Bastian Germann , linux-xfs@vger.kernel.org, Steve Langasek Subject: Re: [PATCH 3/4] debian: Regenerate config.guess using debhelper Message-ID: <20210221220443.GO4662@dread.disaster.area> References: <20210220121610.3982-1-bastiangermann@fishpost.de> <20210220121610.3982-4-bastiangermann@fishpost.de> <20210221041139.GL4662@dread.disaster.area> <840CCF3D-7A20-4E35-BA9C-DEC9C05EE70A@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <840CCF3D-7A20-4E35-BA9C-DEC9C05EE70A@canonical.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 cx=a_idp_d a=JD06eNgDs9tuHP7JIKoLzw==:117 a=JD06eNgDs9tuHP7JIKoLzw==:17 a=kj9zAlcOel0A:10 a=qa6Q16uM49sA:10 a=7-415B0cAAAA:8 a=VwQbUJbxAAAA:8 a=0q3JwVDr4qjw3R0EPjYA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 a=AjGcO6oz07-iQ99wixmX:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Feb 20, 2021 at 11:16:57PM -0800, Steve Langasek wrote: > > > On February 20, 2021 8:11:39 PM PST, Dave Chinner wrote: > >On Sat, Feb 20, 2021 at 01:16:08PM +0100, Bastian Germann wrote: > >> This is a change introduced in 5.10.0-2ubuntu2 with the changelog: > >> > >> > xfsprogs upstream has regressed config.guess, so use > >> > dh_update_autotools_config. > > > >What regression? > > > >The xfsprogs build generates config.guess with the libtool > >infrastructure installed on the build machine. So I'm not sure > >how/what we've regressed here, because AFAIK we haven't changed > >anything here recently... > > This upstream release ended up with an older version of config.guess in the tarball. Specifically, it was too old to recognize RISC-V as an architecture. So was the RISC-V architecture added to the ubuntu build between the uploads of the previous version of xfsprogs and xfsprogs-5.10.0? Or is this an actual regression where the maintainer signed tarball had RISC-V support in it and now it doesn't? FWIW, where are you getting the tarballs from? Are you downloading the maintainer signed tarballs from here: https://mirrors.edge.kernel.org/pub/linux/utils/fs/xfs/xfsprogs/ Or pulling the git.kernel.org built tarball that is autogenerated from the release tag? > >> @echo "== dpkg-buildpackage: configure" 1>&2 > >> $(checkdir) > >> AUTOHEADER=/bin/true dh_autoreconf > >> + dh_update_autotools_config > >> $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h > > > >Why would running at tool that does a search-n-replace of built > >config.guess files do anything when run before the build runs > >libtoolize to copy in the config.guess file it uses? I'm a bit > >confused by this... > > Autoreconf was not copying in a newer version of config.guess from the system, because of the specific subset of autotools used by this project. That sounds wrong. AIUI, autoreconf doesn't copy in anything. $ man 7 dh-autoreconf .... CAVEATS dh_autoreconf is mostly a superset of the dh_update_autotools_config debhelper command included in debhelper since version 9.20160115. When using the dh sequencer, dh_update_autotools_config is run before dh_autoreconf and updates the config.guess and config.sub files. This is required in cases where autoreconf does not update config.guess and config.sub itself. So isn't the dh_update_autotools_config call in the wrong place here? Cheers, Dave. -- Dave Chinner david@fromorbit.com