From: "Darrick J. Wong" <djwong@kernel.org>
To: Geert Hendrickx <geert@hendrickx.be>
Cc: Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: xfs_admin -O feature upgrade feedback
Date: Wed, 3 Mar 2021 09:00:19 -0800 [thread overview]
Message-ID: <20210303170019.GH7269@magnolia> (raw)
In-Reply-To: <YD+NF63sGji+OBtc@vera.ghen.be>
On Wed, Mar 03, 2021 at 02:20:23PM +0100, Geert Hendrickx wrote:
> On Wed, Mar 03, 2021 at 06:50:04 -0500, Brian Foster wrote:
> > Maybe a simple compromise is a verbose option for xfs_admin itself..?
> > I.e., the normal use case operates as it does now, but the failure case
> > would print something like:
> >
> > "Feature conversion failed. Retry with -v for detailed error output."
Ugh, no, by the time the sysadmin /reruns/ repair, the original output
is lost. Frankly I'd rather xfs_admin stop interfering with
stdout/stderr and teach repair to suppress errors due to upgrades.
--D
> > ... and then 'xfs_admin -v ...' would just pass through xfs_repair
> > output. Eh?
>
>
> Good suggestion, that should cover it.
>
>
> Geert
>
>
next prev parent reply other threads:[~2021-03-04 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YDy+OmsVCkTfiMPp@vera.ghen.be>
2021-03-01 19:18 ` xfs_admin -O feature upgrade feedback Darrick J. Wong
2021-03-01 22:31 ` Geert Hendrickx
2021-03-02 12:19 ` Brian Foster
2021-03-02 22:57 ` Geert Hendrickx
2021-03-03 11:50 ` Brian Foster
2021-03-03 13:20 ` Geert Hendrickx
2021-03-03 17:00 ` Darrick J. Wong [this message]
2021-03-04 2:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303170019.GH7269@magnolia \
--to=djwong@kernel.org \
--cc=bfoster@redhat.com \
--cc=geert@hendrickx.be \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).