From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de, dchinner@redhat.com,
christian.brauner@ubuntu.com
Subject: Re: [PATCH v2.1 2/4] xfs: avoid buffer deadlocks when walking fs inodes
Date: Mon, 8 Mar 2021 09:37:03 +1100 [thread overview]
Message-ID: <20210307223703.GX4662@dread.disaster.area> (raw)
In-Reply-To: <20210307203638.GJ3419940@magnolia>
On Sun, Mar 07, 2021 at 12:36:38PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> When we're servicing an INUMBERS or BULKSTAT request or running
> quotacheck, grab an empty transaction so that we can use its inherent
> recursive buffer locking abilities to detect inode btree cycles without
> hitting ABBA buffer deadlocks.
>
> Found by fuzzing an inode btree pointer to introduce a cycle into the
> tree (xfs/365).
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> v2.1: actually pass tp in the bulkstat_single case
> ---
> fs/xfs/xfs_itable.c | 42 +++++++++++++++++++++++++++++++++++++-----
> fs/xfs/xfs_iwalk.c | 32 +++++++++++++++++++++++++++-----
> 2 files changed, 64 insertions(+), 10 deletions(-)
Looks ok, but I can't help but wonder if this case should flag
corruption if lock recursion does actually occur...
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-03-07 22:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 20:25 [PATCHSET v2 0/4] xfs: small fixes for 5.12 Darrick J. Wong
2021-03-07 20:25 ` [PATCH 1/4] xfs: fix quota accounting when a mount is idmapped Darrick J. Wong
2021-03-07 22:28 ` Dave Chinner
2021-03-07 20:25 ` [PATCH 2/4] xfs: avoid buffer deadlocks when walking fs inodes Darrick J. Wong
2021-03-07 20:36 ` [PATCH v2.1 " Darrick J. Wong
2021-03-07 22:37 ` Dave Chinner [this message]
2021-03-08 3:56 ` Darrick J. Wong
2021-03-08 7:56 ` Christoph Hellwig
2021-03-07 20:25 ` [PATCH 3/4] xfs: force log and push AIL to clear pinned inodes when aborting mount Darrick J. Wong
2021-03-07 23:01 ` Dave Chinner
2021-03-08 4:47 ` Darrick J. Wong
2021-03-08 4:48 ` [PATCH v2.1 " Darrick J. Wong
2021-03-08 9:16 ` Christoph Hellwig
2021-03-08 23:42 ` Dave Chinner
2021-03-08 7:53 ` [PATCH " Christoph Hellwig
2021-03-07 20:26 ` [PATCH 4/4] xfs: drop freeze protection when running GETFSMAP Darrick J. Wong
2021-03-07 23:05 ` Dave Chinner
2021-03-08 4:45 ` Darrick J. Wong
2021-03-08 7:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307223703.GX4662@dread.disaster.area \
--to=david@fromorbit.com \
--cc=christian.brauner@ubuntu.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox