From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: mark xfs_bmap_set_attrforkoff static
Date: Tue, 9 Mar 2021 09:44:25 -0800 [thread overview]
Message-ID: <20210309174425.GW3419940@magnolia> (raw)
In-Reply-To: <20210225081355.139766-1-hch@lst.de>
On Thu, Feb 25, 2021 at 09:13:55AM +0100, Christoph Hellwig wrote:
> xfs_bmap_set_attrforkoff is only used inside of xfs_bmap.c, so mark it
> static.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks fine, assuming you're all fine with Dave's other patch to
initialize attr forks when ACLs are turned on?
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 +-
> fs/xfs/libxfs/xfs_bmap.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index e0905ad171f0a5..d53afd82e109e5 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -1028,7 +1028,7 @@ xfs_bmap_add_attrfork_local(
> }
>
> /* Set an inode attr fork off based on the format */
> -int
> +static int
> xfs_bmap_set_attrforkoff(
> struct xfs_inode *ip,
> int size,
> diff --git a/fs/xfs/libxfs/xfs_bmap.h b/fs/xfs/libxfs/xfs_bmap.h
> index 6747e97a794901..66a7b5b755a493 100644
> --- a/fs/xfs/libxfs/xfs_bmap.h
> +++ b/fs/xfs/libxfs/xfs_bmap.h
> @@ -186,7 +186,6 @@ static inline bool xfs_bmap_is_written_extent(struct xfs_bmbt_irec *irec)
> void xfs_trim_extent(struct xfs_bmbt_irec *irec, xfs_fileoff_t bno,
> xfs_filblks_t len);
> int xfs_bmap_add_attrfork(struct xfs_inode *ip, int size, int rsvd);
> -int xfs_bmap_set_attrforkoff(struct xfs_inode *ip, int size, int *version);
> void xfs_bmap_local_to_extents_empty(struct xfs_trans *tp,
> struct xfs_inode *ip, int whichfork);
> void __xfs_bmap_add_free(struct xfs_trans *tp, xfs_fsblock_t bno,
> --
> 2.29.2
>
prev parent reply other threads:[~2021-03-09 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 8:13 [PATCH] xfs: mark xfs_bmap_set_attrforkoff static Christoph Hellwig
2021-03-09 17:44 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309174425.GW3419940@magnolia \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox