Re: [PATCH 06/45] xfs: CIL checkpoint flushes caches unconditionally

Brian Foster
2021-03-15T14:44:28Z

On Fri, Mar 05, 2021 at 04:11:04PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
...
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_log_cil.c | 31 +++++++++++++++++++++++++++----
> 1 file changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
> index 1e5fd6f268c2..b4cdb8b6c4c3 100644
> --- a/fs/xfs/xfs_log_cil.c
> +++ b/fs/xfs/xfs_log_cil.c
...
> @@ -719,10 +721,25 @@ xlog_cil_push_work(
> spin_unlock(&cil->xc_push_lock);
>
> /*
> - * pull all the log vectors off the items in the CIL, and
> - * remove the items from the CIL. We don't need the CIL lock
> - * here because it's only needed on the transaction commit
> - * side which is currently locked out by the flush lock.
> + * The CIL is stable at this point - nothing new will be added to it
> + * because we hold the flush lock exclusively. Hence we can now issue
> + * a cache flush to ensure all the completed metadata in the journal we
> + * are about to overwrite is on stable storage.
> + *
> + * This avoids the need to have the iclogs issue REQ_PREFLUSH based
> + * cache flushes to provide this ordering guarantee, and hence for CIL
> + * checkpoints that require hundreds or thousands of log writes no
> + * longer need to issue device cache flushes to provide metadata
> + * writeback ordering.
> + */

I don't think we need to have code comments to explain why some other
code doesn't do something or doesn't exist. This seems like something
that should stick to the commit log description (between this patch and
the future patch that removes the historical behavior). IOW, I'd just
drop that second paragraph.

Otherwise (and modulo my previous thoughts on the bio) LGTM:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> + xfs_flush_bdev_async(&bio, log->l_mp->m_ddev_targp->bt_bdev,
> + &bdev_flush);
> +
> + /*
> + * Pull all the log vectors off the items in the CIL, and remove the
> + * items from the CIL. We don't need the CIL lock here because it's only
> + * needed on the transaction commit side which is currently locked out
> + * by the flush lock.
> */
> lv = NULL;
> num_iovecs = 0;
> @@ -806,6 +823,12 @@ xlog_cil_push_work(
> lvhdr.lv_iovecp = &lhdr;
> lvhdr.lv_next = ctx->lv_chain;
>
> + /*
> + * Before we format and submit the first iclog, we have to ensure that
> + * the metadata writeback ordering cache flush is complete.
> + */
> + wait_for_completion(&bdev_flush);
> +
> error = xlog_write(log, &lvhdr, tic, &ctx->start_lsn, NULL, 0, true);
> if (error)
> goto out_abort_free_ticket;
> --
> 2.28.0
>