Re: [PATCH 05/45] xfs: async blkdev cache flush

Christoph Hellwig
2021-03-16T08:45:02Z

On Mon, Mar 15, 2021 at 09:32:22AM -0700, Darrick J. Wong wrote:
> Yes, I agree with that principle. However, the use case for !done isn't
> clear ot me -- what is the point of issuing a flush and not waiting for
> the results?

There is none. This check should go away.

>
> Can PREFLUSHes generate IO errors? And if they do, why don't we return
> the error to the caller?

The caller owns the bio and can look at bi_status itself.